From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19326 invoked by alias); 26 Nov 2012 11:57:31 -0000 Received: (qmail 19318 invoked by uid 22791); 26 Nov 2012 11:57:30 -0000 X-SWARE-Spam-Status: No, hits=-7.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Nov 2012 11:57:21 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qAQBvJDC020631 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 26 Nov 2012 06:57:19 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qAQBvIVF031038; Mon, 26 Nov 2012 06:57:18 -0500 Message-ID: <50B3591D.7070401@redhat.com> Date: Mon, 26 Nov 2012 11:57:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH] use gdbarch_addr_bits_remove for entry point address References: <1353404184-22073-1-git-send-email-yao@codesourcery.com> <50AFD573.1090601@gmail.com> <50B0ABF9.1080606@codesourcery.com> In-Reply-To: <50B0ABF9.1080606@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00649.txt.bz2 This version is OK, but please fix up the ChangeLog entry. > 2012-11-24 Daniel Jacobowitz > Kazu Hirata > Yao Qi > > * objfiles.c (entry_point_address_query): Move some code ... > (init_entry_point_info): ... here. Please be more specific: * objfiles.c (entry_point_address_query): Call gdbarch_convert_from_func_ptr_addr and gdbarch_addr_bits_remove here ... (init_entry_point_info): ... instead of here. That's more useful for archaeology. > * solib-svr4.c (exec_entry_point): Likewise. "Likewise" here doesn't make sense. Perhaps: * solib-svr4.c (exec_entry_point): Call gdbarch_addr_bits_remove. > * symfile.c (generic_load): Call gdbarch_addr_bits_remove on > the entry address. -- Pedro Alves