[PATCH] Uniquify test name py-test.exp

[PATCH] Uniquify test name py-test.exp

[Andrew Burgess]

While working on something else I regressed a test in py-test.exp, and spotted that lots of the tests in here have duplicate names.

Patch adds a few calls to with_test_prefix and adds some extra text to test names in order to make all the test names unique.

The patch below **does not** include all the whitespace changes introduced by the nested nature of 'with_test_prefix "prefix" {...}', I can post the full patch if needed, but I thought this would be easier to read.  If/when I commit I'd push a version with correct indentation.

Ok to apply?

Thanks,
Andrew

gdb/testsuite/ChangeLog

2012-11-13  Andrew Burgess  <aburgess@broadcom.com>

	* gdb.python/py-type.exp: Uniquify test names.


diff --git a/gdb/testsuite/gdb.python/py-type.exp b/gdb/testsuite/gdb.python/py-type.exp
index 43e1689..1112dc4 100644
--- a/gdb/testsuite/gdb.python/py-type.exp
+++ b/gdb/testsuite/gdb.python/py-type.exp
@@ -56,6 +56,7 @@ proc runto_bp {bp} {
 }
 
 proc test_fields {lang} {
+  with_test_prefix "test_fields" {
   global gdb_prompt
 
   # .fields() of a typedef should still return the underlying field list
@@ -65,9 +66,9 @@ proc test_fields {lang} {
   if {$lang == "c++"} {
       # Test usage with a class
       gdb_py_test_silent_cmd "print c" "print value (c)" 1
-      gdb_py_test_silent_cmd "python c = gdb.history (0)" "get value from history" 1
-      gdb_py_test_silent_cmd "python fields = c.type.fields()" "get fields" 1
-      gdb_test "python print len(fields)" "2" "Check number of fields"
+      gdb_py_test_silent_cmd "python c = gdb.history (0)" "get value (c) from history" 1
+      gdb_py_test_silent_cmd "python fields = c.type.fields()" "get fields from c.type" 1
+      gdb_test "python print len(fields)" "2" "Check number of fields (c)"
       gdb_test "python print fields\[0\].name" "c" "Check class field c name"
       gdb_test "python print fields\[1\].name" "d" "Check class field d name"
 
@@ -78,9 +79,9 @@ proc test_fields {lang} {
 
   # Test normal fields usage in structs.
   gdb_py_test_silent_cmd "print st" "print value (st)" 1
-  gdb_py_test_silent_cmd "python st = gdb.history (0)" "get value from history" 1
-  gdb_py_test_silent_cmd "python fields = st.type.fields()" "get fields" 1
-  gdb_test "python print len(fields)" "2" "Check number of fields"
+  gdb_py_test_silent_cmd "python st = gdb.history (0)" "get value (st) from history" 1
+  gdb_py_test_silent_cmd "python fields = st.type.fields()" "get fields from st.type" 1
+  gdb_test "python print len(fields)" "2" "Check number of fields (st)"
   gdb_test "python print fields\[0\].name" "a" "Check structure field a name"
   gdb_test "python print fields\[1\].name" "b" "Check structure field b name"
 
@@ -90,7 +91,7 @@ proc test_fields {lang} {
     "Check that dir includes name"
 
   # Test Python mapping behavior of gdb.Type for structs/classes
-  gdb_test "python print len(st.type)" "2" "Check number of fields"
+  gdb_test "python print len(st.type)" "2" "Check number of fields (st.type)"
   gdb_test "python print st.type\['a'\].name" "a" "Check fields lookup by name"
     gdb_test "python print \[v.bitpos for v in st.type.itervalues()\]" {\[0L, 32L\]} "Check fields iteration over values"
     gdb_test "python print \[(n, v.bitpos) for (n, v) in st.type.items()\]" {\[\('a', 0L\), \('b', 32L\)\]} "Check fields items list"
@@ -109,7 +110,7 @@ proc test_fields {lang} {
   
   # Test regression PR python/10805
   gdb_py_test_silent_cmd "print ar" "print value (ar)" 1
-  gdb_py_test_silent_cmd "python ar = gdb.history (0)" "get value from  history" 1
+  gdb_py_test_silent_cmd "python ar = gdb.history (0)" "get value (ar) from history" 1
   gdb_test "python fields = ar.type.fields()"
   gdb_test "python print len(fields)" "1" "Check the number of fields"
   gdb_test "python print fields\[0\].type" "<range type>" "Check array field type"
@@ -128,7 +129,7 @@ proc test_fields {lang} {
 
   # INVALID: Casting single int to vector of two integers, doesn't work as
   # we don't replicate anymore.
-  kfail "apb/1" "*-*-*"
+    #kfail "apb/1" "*-*-*"
   gdb_py_test_silent_cmd \
       "python vec1 = ar\[0\].cast(ar\[0\].type.vector(1))" "set vec1" 1
   gdb_test "python print vec1" ".1, 1." "cast to vector with one argument"
@@ -140,51 +141,63 @@ proc test_fields {lang} {
       "python vec3 = ar\[1\].cast(ar\[1\].type.vector(1))" "set vec3" 1
   gdb_test "python print vec1 == vec3" "False"
 }
+}
 
 proc test_enums {} {
+  with_test_prefix "test_enum" {
   gdb_py_test_silent_cmd "print e" "print value (e)" 1
-  gdb_py_test_silent_cmd "python e = gdb.history (0)" "get value from  history" 1
-  gdb_py_test_silent_cmd "python fields = e.type.fields()" "get value from history" 1
+      gdb_py_test_silent_cmd "python e = gdb.history (0)" "get value (e) from history" 1
+      gdb_py_test_silent_cmd "python fields = e.type.fields()" "extract type fields from e" 1
   gdb_test "python print len(fields)" "3" "Check the number of enum fields"
-  gdb_test "python print fields\[0\].name" "v1" "Check enum field[0] name"
-  gdb_test "python print fields\[1\].name" "v2" "Check enum field [1]name"
+      gdb_test "python print fields\[0\].name" "v1" "Check enum field\[0\] name"
+      gdb_test "python print fields\[1\].name" "v2" "Check enum field\[1\]name"
 
   # Ditto but by mapping operations
-  gdb_test "python print len(e.type)" "3" "Check the number of enum fields"
-  gdb_test "python print e.type\['v1'\].name" "v1" "Check enum field lookup by name"
-  gdb_test "python print e.type\['v3'\].name" "v3" "Check enum field lookup by name"
+      gdb_test "python print len(e.type)" "3" "Check the number of type fields"
+      gdb_test "python print e.type\['v1'\].name" "v1" "Check enum field lookup by name (v1)"
+      gdb_test "python print e.type\['v3'\].name" "v3" "Check enum field lookup by name (v2)"
     gdb_test "python print \[v.enumval for v in e.type.itervalues()\]" {\[0L, 1L, 2L\]} "Check num fields iteration over values"
     gdb_test "python print \[(n, v.enumval) for (n, v) in e.type.items()\]" {\[\('v1', 0L\), \('v2', 1L\), \('v3', 2L\)\]} "Check enum fields items list"
+  }
 }
 proc test_base_class {} {
+  with_test_prefix "test_base_class" {
   gdb_py_test_silent_cmd "print d" "print value (d)" 1
-  gdb_py_test_silent_cmd "python d = gdb.history (0)" "get value from  history" 1
-  gdb_py_test_silent_cmd "python fields = d.type.fields()" "get value from history" 1
+    gdb_py_test_silent_cmd "python d = gdb.history (0)" "get value (d) from history" 1
+    gdb_py_test_silent_cmd "python fields = d.type.fields()" "extract type fields from d" 1
   gdb_test "python print len(fields)" "3" "Check the number of fields"
-  gdb_test "python print fields\[0\].is_base_class" "True" "Check base class"
-  gdb_test "python print fields\[1\].is_base_class" "False" "Check base class"
+    gdb_test "python print fields\[0\].is_base_class" "True" "Check base class (fields\[0\])"
+    gdb_test "python print fields\[1\].is_base_class" "False" "Check base class (fields\[1\])"
+  }
 }
 
 proc test_range {} {
-
+  with_test_prefix "test_range" {
+    with_test_prefix "on ranged value" {
   # Test a valid range request.
   gdb_py_test_silent_cmd "print ar" "print value (ar)" 1
-  gdb_py_test_silent_cmd "python ar = gdb.history (0)" "get value from history" 1
+      gdb_py_test_silent_cmd "python ar = gdb.history (0)" "get value (ar) from history" 1
   gdb_test "python print len(ar.type.range())" "2" "Check correct tuple length"
-  gdb_test "python print ar.type.range()\[0\]" "0" "Check low range"
-  gdb_test "python print ar.type.range()\[1\]" "1" "Check high range"
+      gdb_test "python print ar.type.range()\[0\]" "0" "Check range low bound"
+      gdb_test "python print ar.type.range()\[1\]" "1" "Check range high bound"
+    }
 
+    with_test_prefix "on ranged type" {
   # Test a range request on a ranged type.
   gdb_py_test_silent_cmd "print ar" "print value (ar)" 1
-  gdb_py_test_silent_cmd "python ar = gdb.history (0)" "get value from  history" 1
+      gdb_py_test_silent_cmd "python ar = gdb.history (0)" "get value (ar) from history" 1
   gdb_py_test_silent_cmd "python fields = ar.type.fields()" "get fields" 1
-  gdb_test "python print fields\[0\].type.range()\[0\]" "0" "Check range type low bound"
-  gdb_test "python print fields\[0\].type.range()\[1\]" "1" "Check range type high bound"
+      gdb_test "python print fields\[0\].type.range()\[0\]" "0" "Check range low bound"
+      gdb_test "python print fields\[0\].type.range()\[1\]" "1" "Check range high bound"
+    }
 
+    with_test_prefix "on unranged value" {
   # Test where a range does not exist.
   gdb_py_test_silent_cmd "print st" "print value (st)" 1
-  gdb_py_test_silent_cmd "python st = gdb.history (0)" "get value from history" 1
+      gdb_py_test_silent_cmd "python st = gdb.history (0)" "get value (st) from history" 1
   gdb_test "python print st.type.range()" "RuntimeError: This type does not have a range.*" "Check range for non ranged type."
+    }
+  }
 }
 
 # Some tests of template arguments.

Re: [PATCH] Uniquify test name py-test.exp

[Andrew Burgess]

On 13/11/2012 9:51 AM, Andrew Burgess wrote:
> While working on something else I regressed a test in py-test.exp, and spotted that lots of the tests in here have duplicate names.
> 
> Patch adds a few calls to with_test_prefix and adds some extra text to test names in order to make all the test names unique.
> 
> The patch below **does not** include all the whitespace changes introduced by the nested nature of 'with_test_prefix "prefix" {...}', I can post the full patch if needed, but I thought this would be easier to read.  If/when I commit I'd push a version with correct indentation.
> 
> Ok to apply?

No.  I stupidly put the wrong version of this patch in the email.  I'll try again.

Again, without whitespace change.

How's this one?

Sorry for the noise.
Andrew

gdb/testsuite/ChangeLog

2012-11-13  Andrew Burgess  <aburgess@broadcom.com>

	* gdb.python/py-type.exp: Uniquify test names.



diff --git a/gdb/testsuite/gdb.python/py-type.exp b/gdb/testsuite/gdb.python/py-type.exp
index b997c51..0f77229 100644
--- a/gdb/testsuite/gdb.python/py-type.exp
+++ b/gdb/testsuite/gdb.python/py-type.exp
@@ -56,6 +56,7 @@ proc runto_bp {bp} {
 }
 
 proc test_fields {lang} {
+  with_test_prefix "test_fields" {
   global gdb_prompt
 
   # .fields() of a typedef should still return the underlying field list
@@ -64,10 +65,10 @@ proc test_fields {lang} {
 
   if {$lang == "c++"} {
       # Test usage with a class
-      gdb_py_test_silent_cmd "print c" "print value" 1
-      gdb_py_test_silent_cmd "python c = gdb.history (0)" "get value from history" 1
-      gdb_py_test_silent_cmd "python fields = c.type.fields()" "get fields" 1
-      gdb_test "python print len(fields)" "2" "Check number of fields"
+      gdb_py_test_silent_cmd "print c" "print value (c)" 1
+      gdb_py_test_silent_cmd "python c = gdb.history (0)" "get value (c) from history" 1
+      gdb_py_test_silent_cmd "python fields = c.type.fields()" "get fields from c.type" 1
+      gdb_test "python print len(fields)" "2" "Check number of fields (c)"
       gdb_test "python print fields\[0\].name" "c" "Check class field c name"
       gdb_test "python print fields\[1\].name" "d" "Check class field d name"
 
@@ -77,10 +78,10 @@ proc test_fields {lang} {
   }
 
   # Test normal fields usage in structs.
-  gdb_py_test_silent_cmd "print st" "print value" 1
-  gdb_py_test_silent_cmd "python st = gdb.history (0)" "get value from history" 1
-  gdb_py_test_silent_cmd "python fields = st.type.fields()" "get fields" 1
-  gdb_test "python print len(fields)" "2" "Check number of fields"
+  gdb_py_test_silent_cmd "print st" "print value (st)" 1
+  gdb_py_test_silent_cmd "python st = gdb.history (0)" "get value (st) from history" 1
+  gdb_py_test_silent_cmd "python fields = st.type.fields()" "get fields from st.type" 1
+  gdb_test "python print len(fields)" "2" "Check number of fields (st)"
   gdb_test "python print fields\[0\].name" "a" "Check structure field a name"
   gdb_test "python print fields\[1\].name" "b" "Check structure field b name"
 
@@ -90,7 +91,7 @@ proc test_fields {lang} {
     "Check that dir includes name"
 
   # Test Python mapping behavior of gdb.Type for structs/classes
-  gdb_test "python print len(st.type)" "2" "Check number of fields"
+  gdb_test "python print len(st.type)" "2" "Check number of fields (st.type)"
   gdb_test "python print st.type\['a'\].name" "a" "Check fields lookup by name"
     gdb_test "python print \[v.bitpos for v in st.type.itervalues()\]" {\[0L, 32L\]} "Check fields iteration over values"
     gdb_test "python print \[(n, v.bitpos) for (n, v) in st.type.items()\]" {\[\('a', 0L\), \('b', 32L\)\]} "Check fields items list"
@@ -108,8 +109,8 @@ proc test_fields {lang} {
   gdb_test "python print not not st.type\['a'\].type" "True"
   
   # Test regression PR python/10805
-  gdb_py_test_silent_cmd "print ar" "print value" 1
-  gdb_py_test_silent_cmd "python ar = gdb.history (0)" "get value from  history" 1
+  gdb_py_test_silent_cmd "print ar" "print value (ar)" 1
+  gdb_py_test_silent_cmd "python ar = gdb.history (0)" "get value (ar) from history" 1
   gdb_test "python fields = ar.type.fields()"
   gdb_test "python print len(fields)" "1" "Check the number of fields"
   gdb_test "python print fields\[0\].type" "<range type>" "Check array field type"
@@ -136,51 +137,63 @@ proc test_fields {lang} {
       "python vec3 = ar\[1\].cast(ar\[1\].type.vector(1))" "set vec3" 1
   gdb_test "python print vec1 == vec3" "False"
 }
+}
 
 proc test_enums {} {
-  gdb_py_test_silent_cmd "print e" "print value" 1
-  gdb_py_test_silent_cmd "python e = gdb.history (0)" "get value from  history" 1
-  gdb_py_test_silent_cmd "python fields = e.type.fields()" "get value from history" 1
+  with_test_prefix "test_enum" {
+    gdb_py_test_silent_cmd "print e" "print value (e)" 1
+    gdb_py_test_silent_cmd "python e = gdb.history (0)" "get value (e) from history" 1
+    gdb_py_test_silent_cmd "python fields = e.type.fields()" "extract type fields from e" 1
   gdb_test "python print len(fields)" "3" "Check the number of enum fields"
-  gdb_test "python print fields\[0\].name" "v1" "Check enum field name"
-  gdb_test "python print fields\[1\].name" "v2" "Check enum field name"
+    gdb_test "python print fields\[0\].name" "v1" "Check enum field\[0\] name"
+    gdb_test "python print fields\[1\].name" "v2" "Check enum field\[1\]name"
 
   # Ditto but by mapping operations
-  gdb_test "python print len(e.type)" "3" "Check the number of enum fields"
-  gdb_test "python print e.type\['v1'\].name" "v1" "Check enum field lookup by name"
-  gdb_test "python print e.type\['v3'\].name" "v3" "Check enum field lookup by name"
+    gdb_test "python print len(e.type)" "3" "Check the number of type fields"
+    gdb_test "python print e.type\['v1'\].name" "v1" "Check enum field lookup by name (v1)"
+    gdb_test "python print e.type\['v3'\].name" "v3" "Check enum field lookup by name (v2)"
     gdb_test "python print \[v.enumval for v in e.type.itervalues()\]" {\[0L, 1L, 2L\]} "Check num fields iteration over values"
     gdb_test "python print \[(n, v.enumval) for (n, v) in e.type.items()\]" {\[\('v1', 0L\), \('v2', 1L\), \('v3', 2L\)\]} "Check enum fields items list"
+  }
 }
 proc test_base_class {} {
-  gdb_py_test_silent_cmd "print d" "print value" 1
-  gdb_py_test_silent_cmd "python d = gdb.history (0)" "get value from  history" 1
-  gdb_py_test_silent_cmd "python fields = d.type.fields()" "get value from history" 1
+  with_test_prefix "test_base_class" {
+    gdb_py_test_silent_cmd "print d" "print value (d)" 1
+    gdb_py_test_silent_cmd "python d = gdb.history (0)" "get value (d) from history" 1
+    gdb_py_test_silent_cmd "python fields = d.type.fields()" "extract type fields from d" 1
   gdb_test "python print len(fields)" "3" "Check the number of fields"
-  gdb_test "python print fields\[0\].is_base_class" "True" "Check base class"
-  gdb_test "python print fields\[1\].is_base_class" "False" "Check base class"
+    gdb_test "python print fields\[0\].is_base_class" "True" "Check base class (fields\[0\])"
+    gdb_test "python print fields\[1\].is_base_class" "False" "Check base class (fields\[1\])"
+  }
 }
 
 proc test_range {} {
-
+  with_test_prefix "test_range" {
+    with_test_prefix "on ranged value" {
   # Test a valid range request.
-  gdb_py_test_silent_cmd "print ar" "print value" 1
-  gdb_py_test_silent_cmd "python ar = gdb.history (0)" "get value from history" 1
+      gdb_py_test_silent_cmd "print ar" "print value (ar)" 1
+      gdb_py_test_silent_cmd "python ar = gdb.history (0)" "get value (ar) from history" 1
   gdb_test "python print len(ar.type.range())" "2" "Check correct tuple length"
-  gdb_test "python print ar.type.range()\[0\]" "0" "Check low range"
-  gdb_test "python print ar.type.range()\[1\]" "1" "Check high range"
+      gdb_test "python print ar.type.range()\[0\]" "0" "Check range low bound"
+      gdb_test "python print ar.type.range()\[1\]" "1" "Check range high bound"
+    }
 
+    with_test_prefix "on ranged type" {
   # Test a range request on a ranged type.
-  gdb_py_test_silent_cmd "print ar" "print value" 1
-  gdb_py_test_silent_cmd "python ar = gdb.history (0)" "get value from  history" 1
+      gdb_py_test_silent_cmd "print ar" "print value (ar)" 1
+      gdb_py_test_silent_cmd "python ar = gdb.history (0)" "get value (ar) from history" 1
   gdb_py_test_silent_cmd "python fields = ar.type.fields()" "get fields" 1
-  gdb_test "python print fields\[0\].type.range()\[0\]" "0" "Check range type low bound"
-  gdb_test "python print fields\[0\].type.range()\[1\]" "1" "Check range type high bound"
+      gdb_test "python print fields\[0\].type.range()\[0\]" "0" "Check range low bound"
+      gdb_test "python print fields\[0\].type.range()\[1\]" "1" "Check range high bound"
+    }
 
+    with_test_prefix "on unranged value" {
   # Test where a range does not exist.
-  gdb_py_test_silent_cmd "print st" "print value" 1
-  gdb_py_test_silent_cmd "python st = gdb.history (0)" "get value from history" 1
+      gdb_py_test_silent_cmd "print st" "print value (st)" 1
+      gdb_py_test_silent_cmd "python st = gdb.history (0)" "get value (st) from history" 1
   gdb_test "python print st.type.range()" "RuntimeError: This type does not have a range.*" "Check range for non ranged type."
+    }
+  }
 }
 
 # Some tests of template arguments.
@@ -221,16 +234,20 @@ restart_gdb "${binfile}"
 # Skip all tests if Python scripting is not enabled.
 if { [skip_python_tests] } { continue }
 
-runto_bp "break to inspect struct and array."
-test_fields "c"
-test_enums
+with_test_prefix "lang_c" {
+    runto_bp "break to inspect struct and array."
+    test_fields "c"
+    test_enums
+}
 
 # Perform C++ Tests.
 build_inferior "${binfile}-cxx" "c++"
 restart_gdb "${binfile}-cxx"
-runto_bp "break to inspect struct and array."
-test_fields "c++"
-test_base_class
-test_range
-test_template
-test_enums
+with_test_prefix "lang_cpp" {
+    runto_bp "break to inspect struct and array."
+    test_fields "c++"
+    test_base_class
+    test_range
+    test_template
+    test_enums
+}

Re: [PATCH] Uniquify test name py-test.exp

[Tom Tromey]

>>>>> "Andrew" == Andrew Burgess <aburgess@broadcom.com> writes:

Andrew> Again, without whitespace change.

Andrew> How's this one?

Looks good.  Thanks.

Andrew> Sorry for the noise.

No problem.

Tom

Re: [PATCH] Uniquify test name py-test.exp

[Andrew Burgess]

On 13/11/2012 4:20 PM, Tom Tromey wrote:
>>>>>> "Andrew" == Andrew Burgess <aburgess@broadcom.com> writes:
> 
> Andrew> Again, without whitespace change.
> 
> Andrew> How's this one?
> 
> Looks good.  Thanks.

Committed.

Thanks,
Andrew