From: Pedro Alves <palves@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GDB <gdb-patches@sourceware.org>
Subject: Re: PATCH: Use is_x86_like_target to check x86 targets
Date: Thu, 11 Oct 2012 17:38:00 -0000 [thread overview]
Message-ID: <507703EA.40604@redhat.com> (raw)
In-Reply-To: <50770186.9090002@redhat.com>
On 10/11/2012 06:27 PM, Pedro Alves wrote:
> Some of these tests are written in assembly and have things like:
>
> "gdb1435:\n"
> " pushl %ebp\n"
> " mov %esp, %ebp\n"
> " call " SYMBOL (trap) "\n"
>
> I thought this use of 32-bit regs wouldn't be correct for x32.
Nevermind, that was silly.
Patch is OK.
--
Pedro Alves
prev parent reply other threads:[~2012-10-11 17:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 15:29 H.J. Lu
2012-10-11 17:27 ` Pedro Alves
2012-10-11 17:37 ` H.J. Lu
2012-10-11 17:38 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507703EA.40604@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox