From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-95177-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27709 invoked by alias); 11 Oct 2012 17:38:01 -0000
Received: (qmail 27573 invoked by uid 22791); 11 Oct 2012 17:38:00 -0000
X-SWARE-Spam-Status: No, hits=-8.6 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 11 Oct 2012 17:37:49 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9BHbmJC028426	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 11 Oct 2012 13:37:48 -0400
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q9BHbkq3013708;	Thu, 11 Oct 2012 13:37:47 -0400
Message-ID: <507703EA.40604@redhat.com>
Date: Thu, 11 Oct 2012 17:38:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1
MIME-Version: 1.0
To: "H.J. Lu" <hjl.tools@gmail.com>
CC: GDB <gdb-patches@sourceware.org>
Subject: Re: PATCH: Use is_x86_like_target to check x86 targets
References: <20121011152929.GC14479@gmail.com> <50770186.9090002@redhat.com>
In-Reply-To: <50770186.9090002@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-10/txt/msg00185.txt.bz2

On 10/11/2012 06:27 PM, Pedro Alves wrote:
> Some of these tests are written in assembly and have things like:
> 
>     "gdb1435:\n"
>     "    pushl %ebp\n"
>     "    mov   %esp, %ebp\n"
>     "    call  " SYMBOL (trap) "\n"
> 
> I thought this use of 32-bit regs wouldn't be correct for x32.

Nevermind, that was silly.

Patch is OK.

-- 
Pedro Alves