From: "Andrew Burgess" <aburgess@broadcom.com>
To: gdb-patches@sourceware.org
Cc: "Pedro Alves" <palves@redhat.com>
Subject: Re: [PATCH] Failure to stop at duplicate breakpoints
Date: Wed, 26 Sep 2012 16:37:00 -0000 [thread overview]
Message-ID: <50632F40.6000708@broadcom.com> (raw)
In-Reply-To: <506319F3.20005@redhat.com>
On 26/09/2012 4:06 PM, Pedro Alves wrote:
> On 09/25/2012 10:48 PM, Andrew Burgess wrote:
>> Pedro,
>>
>> Thanks for taking the time to review my patch. I've addressed the issues you raised, and
>
> Great, thanks. Just one little more I missed before:
>
>> +standard_testfile
>> +
>> +if { [prepare_for_testing ${testfile}.exp ${testfile}] } {
>> + return -1
>> +}
>> +
>> +# Setup for the test, create COUNT breakpoints at the function BREAKPT.
>> +proc test_setup { count } {
>> + global srcfile
>
> global binfile
>
> and
>
>> + clean_restart duplicate-bp
>
> instead:
>
> clean_restart $binfile
>
> Okay with that change. Thanks again.
Have committed with that small fix.
Thanks for your review.
Andrew
prev parent reply other threads:[~2012-09-26 16:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 15:10 Andrew Burgess
2012-09-20 18:40 ` Sergio Durigan Junior
2012-09-20 23:21 ` Andrew Burgess
2012-09-25 16:16 ` Pedro Alves
2012-09-25 21:48 ` Andrew Burgess
2012-09-26 15:06 ` Pedro Alves
2012-09-26 16:37 ` Andrew Burgess [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50632F40.6000708@broadcom.com \
--to=aburgess@broadcom.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox