From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-94874-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4339 invoked by alias); 26 Sep 2012 16:37:50 -0000
Received: (qmail 4173 invoked by uid 22791); 26 Sep 2012 16:37:48 -0000
X-SWARE-Spam-Status: No, hits=-3.4 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mms3.broadcom.com (HELO mms3.broadcom.com) (216.31.210.19)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 26 Sep 2012 16:37:35 +0000
Received: from [10.9.200.131] by mms3.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.5)); Wed, 26 Sep 2012 09:35:16 -0700
X-Server-Uuid: B86B6450-0931-4310-942E-F00ED04CA7AF
Received: from mail-irva-13.broadcom.com (10.11.16.103) by IRVEXCHHUB01.corp.ad.broadcom.com (10.9.200.131) with Microsoft SMTP Server id 8.2.247.2; Wed, 26 Sep 2012 09:37:22 -0700
Received: from [10.177.73.70] (unknown [10.177.73.70]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id D28A340FE4; Wed, 26 Sep 2012 09:37:21 -0700 (PDT)
Message-ID: <50632F40.6000708@broadcom.com>
Date: Wed, 26 Sep 2012 16:37:00 -0000
From: "Andrew Burgess" <aburgess@broadcom.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20120907 Thunderbird/15.0.1
MIME-Version: 1.0
To: gdb-patches@sourceware.org
cc: "Pedro Alves" <palves@redhat.com>
Subject: Re: [PATCH] Failure to stop at duplicate breakpoints
References: <505B31C2.5010203@broadcom.com> <m31uhwfsh5.fsf@redhat.com> <505BA4D2.7070104@broadcom.com> <5061D8B8.2050209@redhat.com> <50622695.3040002@broadcom.com> <506319F3.20005@redhat.com>
In-Reply-To: <506319F3.20005@redhat.com>
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-09/txt/msg00597.txt.bz2

On 26/09/2012 4:06 PM, Pedro Alves wrote:
> On 09/25/2012 10:48 PM, Andrew Burgess wrote:
>> Pedro,
>>
>> Thanks for taking the time to review my patch.  I've addressed the issues you raised, and 
> 
> Great, thanks.  Just one little more I missed before:
> 
>> +standard_testfile
>> +
>> +if { [prepare_for_testing ${testfile}.exp ${testfile}] } {
>> +    return -1
>> +}
>> +
>> +# Setup for the test, create COUNT breakpoints at the function BREAKPT.
>> +proc test_setup { count } {
>> +    global srcfile
> 
>     global binfile
> 
> and
> 
>> +    clean_restart duplicate-bp
> 
> instead:
> 
>     clean_restart $binfile
> 
> Okay with that change.  Thanks again.

Have committed with that small fix.

Thanks for your review.
Andrew