From: Pedro Alves <palves@redhat.com>
To: Siddhesh Poyarekar <siddhesh@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Take 2: Allow printing of 64-bit array sizes in C
Date: Mon, 24 Sep 2012 17:45:00 -0000 [thread overview]
Message-ID: <50609C3E.8070605@redhat.com> (raw)
In-Reply-To: <20120924174713.4192388b@spoyarek>
On 09/24/2012 01:17 PM, Siddhesh Poyarekar wrote:
> +set testfile "longest-types"
> +set srcfile ${testfile}.c
> +set binfile ${objdir}/${subdir}/${testfile}
These three lines can now be replaced with a single
standard_testfile
+
> +if { [prepare_for_testing ${testfile}.exp ${testfile}] } {
...
+struct foo
> +{
> + char buf[0xffff000000];
> + char buf2[2];
> +} *f;
> +
This will fail to compile on 32-bit targets (size too large), and
the complaint will be verbose on the test run's terminal. You can make
the failure quiet by passing "quiet" to prepare_for_testing.
Other than that, looks good to me.
--
Pedro Alves
next prev parent reply other threads:[~2012-09-24 17:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 11:22 [PATCH] " Siddhesh Poyarekar
2012-09-24 11:48 ` Siddhesh Poyarekar
2012-09-24 12:18 ` [PATCH] Take 2: " Siddhesh Poyarekar
2012-09-24 17:45 ` Pedro Alves [this message]
2012-09-25 12:23 ` Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50609C3E.8070605@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=siddhesh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox