From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-94797-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15546 invoked by alias); 24 Sep 2012 17:45:55 -0000
Received: (qmail 15531 invoked by uid 22791); 24 Sep 2012 17:45:53 -0000
X-SWARE-Spam-Status: No, hits=-8.0 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 Sep 2012 17:45:36 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8OHjaeq000669	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Mon, 24 Sep 2012 13:45:36 -0400
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q8OHjZTD029308;	Mon, 24 Sep 2012 13:45:35 -0400
Message-ID: <50609C3E.8070605@redhat.com>
Date: Mon, 24 Sep 2012 17:45:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1
MIME-Version: 1.0
To: Siddhesh Poyarekar <siddhesh@redhat.com>
CC: gdb-patches@sourceware.org
Subject: Re: [PATCH] Take 2: Allow printing of 64-bit array sizes in C
References: <20120924165151.1ad3c613@spoyarek>	<20120924171711.1cba272c@spoyarek> <20120924174713.4192388b@spoyarek>
In-Reply-To: <20120924174713.4192388b@spoyarek>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-09/txt/msg00520.txt.bz2

On 09/24/2012 01:17 PM, Siddhesh Poyarekar wrote:
> +set testfile "longest-types"
> +set srcfile ${testfile}.c
> +set binfile ${objdir}/${subdir}/${testfile}

These three lines can now be replaced with a single

 standard_testfile

+
> +if { [prepare_for_testing ${testfile}.exp ${testfile}] } {

...

+struct foo
> +{
> +  char buf[0xffff000000];
> +  char buf2[2];
> +} *f;
> +

This will fail to compile on 32-bit targets (size too large), and
the complaint will be verbose on the test run's terminal.  You can make
the failure quiet by passing "quiet" to prepare_for_testing.

Other than that, looks good to me.

-- 
Pedro Alves