Re: [commit] Hardware breakpoint errors patch, gdb/MAINTAINERS

[Mike Wrighton <mike_wrighton@mentor.com>]

On 09/17/2012 03:20 PM, Jan Kratochvil wrote:
> Hello Mike,
>
> On Mon, 17 Sep 2012 21:59:16 +0200, Mike Wrighton wrote:
>> I've committed the following patches to fix the hardware breakpoint
>> errors bug and add myself to the gdb/MAINTAINERS list (I had to
>> correct an error in the gdb/Changelog entry hence 2 patches for that
>> file).
> I see now that the real code commit from 12th September
> 	http://sourceware.org/ml/gdb-cvs/2012-09/msg00052.html
>
> also did not have a ChangeLog entry.  Please add one, to the correct place
> chronologically according to the other commits there:
> 	http://sourceware.org/ml/gdb-cvs/2012-09/
>
>
> Thanks,
> Jan

Hi Jan,

Ah yes, I added an entry to the main Changelog rather than the one in 
the gdb subdirectory. I've moved it into the correct place now and 
committed. Let me know if there's anything else I've missed.

Thanks,
Mike


Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/ChangeLog,v
retrieving revision 1.1033
diff -u -p -r1.1033 ChangeLog
--- ChangeLog    15 Sep 2012 17:11:26 -0000    1.1033
+++ ChangeLog    17 Sep 2012 20:35:29 -0000
@@ -13,16 +13,6 @@
      Add libgomp*.o to compare_exclusions for AIX.
      * configure: Regenerate.

-2012-09-12  Mike Wrighton  <wrighton@codesourcery.com>
-
-    * gdb/remote.c (remote_insert_hw_breakpoint): Throw exception if
-    there is an error inserting hardware breakpoints and use the
-    error message from the target.
-
-    * gdb/breakpoint.c (insert_bp_location, insert_breakpoint_locations):
-    Catch this exception and print the error message contained within. 
Do not
-    print the default hardware error breakpoint message in this case.
-
  2012-08-26  H.J. Lu  <hongjiu.lu@intel.com>

      PR binutils/4970
Index: gdb/ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.14672
diff -u -p -r1.14672 ChangeLog
--- gdb/ChangeLog    17 Sep 2012 19:29:52 -0000    1.14672
+++ gdb/ChangeLog    17 Sep 2012 20:35:30 -0000
@@ -179,6 +179,16 @@
      (DECLARE_REGISTRY): Declare struct TAG ## _data.  Use the tagged
      callback typedefs.

+2012-09-12  Mike Wrighton  <wrighton@codesourcery.com>
+
+    * remote.c (remote_insert_hw_breakpoint): Throw exception if
+    there is an error inserting hardware breakpoints and use the
+    error message from the target.
+
+    * breakpoint.c (insert_bp_location, insert_breakpoint_locations):
+    Catch this exception and print the error message contained within. 
Do not
+    print the default hardware error breakpoint message in this case.
+
  2012-09-12  Doug Evans  <dje@google.com>

      * dwarf2read.c (dwarf2_read_addr_index): Fix handling the case where