From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21416 invoked by alias); 17 Sep 2012 20:42:26 -0000 Received: (qmail 21406 invoked by uid 22791); 17 Sep 2012 20:42:24 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 17 Sep 2012 20:42:11 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1TDi8v-0006ss-Rz from Mike_Wrighton@mentor.com ; Mon, 17 Sep 2012 13:42:09 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 17 Sep 2012 13:42:09 -0700 Received: from [172.30.7.20] (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.1.289.1; Mon, 17 Sep 2012 13:42:09 -0700 Message-ID: <50578B21.4070101@mentor.com> Date: Mon, 17 Sep 2012 20:42:00 -0000 From: Mike Wrighton User-Agent: Mozilla/5.0 (X11; Linux i686; rv:14.0) Gecko/20120714 Thunderbird/14.0 MIME-Version: 1.0 To: Jan Kratochvil CC: Subject: Re: [commit] Hardware breakpoint errors patch, gdb/MAINTAINERS References: <50578114.3080307@mentor.com> <20120917202024.GA4423@host2.jankratochvil.net> In-Reply-To: <20120917202024.GA4423@host2.jankratochvil.net> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00328.txt.bz2 On 09/17/2012 03:20 PM, Jan Kratochvil wrote: > Hello Mike, > > On Mon, 17 Sep 2012 21:59:16 +0200, Mike Wrighton wrote: >> I've committed the following patches to fix the hardware breakpoint >> errors bug and add myself to the gdb/MAINTAINERS list (I had to >> correct an error in the gdb/Changelog entry hence 2 patches for that >> file). > I see now that the real code commit from 12th September > http://sourceware.org/ml/gdb-cvs/2012-09/msg00052.html > > also did not have a ChangeLog entry. Please add one, to the correct place > chronologically according to the other commits there: > http://sourceware.org/ml/gdb-cvs/2012-09/ > > > Thanks, > Jan Hi Jan, Ah yes, I added an entry to the main Changelog rather than the one in the gdb subdirectory. I've moved it into the correct place now and committed. Let me know if there's anything else I've missed. Thanks, Mike Index: ChangeLog =================================================================== RCS file: /cvs/src/src/ChangeLog,v retrieving revision 1.1033 diff -u -p -r1.1033 ChangeLog --- ChangeLog 15 Sep 2012 17:11:26 -0000 1.1033 +++ ChangeLog 17 Sep 2012 20:35:29 -0000 @@ -13,16 +13,6 @@ Add libgomp*.o to compare_exclusions for AIX. * configure: Regenerate. -2012-09-12 Mike Wrighton - - * gdb/remote.c (remote_insert_hw_breakpoint): Throw exception if - there is an error inserting hardware breakpoints and use the - error message from the target. - - * gdb/breakpoint.c (insert_bp_location, insert_breakpoint_locations): - Catch this exception and print the error message contained within. Do not - print the default hardware error breakpoint message in this case. - 2012-08-26 H.J. Lu PR binutils/4970 Index: gdb/ChangeLog =================================================================== RCS file: /cvs/src/src/gdb/ChangeLog,v retrieving revision 1.14672 diff -u -p -r1.14672 ChangeLog --- gdb/ChangeLog 17 Sep 2012 19:29:52 -0000 1.14672 +++ gdb/ChangeLog 17 Sep 2012 20:35:30 -0000 @@ -179,6 +179,16 @@ (DECLARE_REGISTRY): Declare struct TAG ## _data. Use the tagged callback typedefs. +2012-09-12 Mike Wrighton + + * remote.c (remote_insert_hw_breakpoint): Throw exception if + there is an error inserting hardware breakpoints and use the + error message from the target. + + * breakpoint.c (insert_bp_location, insert_breakpoint_locations): + Catch this exception and print the error message contained within. Do not + print the default hardware error breakpoint message in this case. + 2012-09-12 Doug Evans * dwarf2read.c (dwarf2_read_addr_index): Fix handling the case where