Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] MI notification on record started and stopped
Date: Fri, 14 Sep 2012 14:13:00 -0000	[thread overview]
Message-ID: <50533B81.2010009@redhat.com> (raw)
In-Reply-To: <50532D6D.5060400@codesourcery.com>

On 09/14/2012 02:13 PM, Yao Qi wrote:
> On 09/14/2012 08:08 PM, Pedro Alves wrote:
>> On 09/14/2012 12:44 PM, Yao Qi wrote:
>>> On 09/14/2012 05:49 PM, Eli Zaretskii wrote:
>>>>> The notification is like '=record-started,thread-group="i1"'.
>>>> ?? If this is a thread-group, why does i1 identify a_process_?  Don't
>>>> you mean "thread group"?
>>>
>>> As matter of fact, this is an inferior, but in MI notification, we call "inferior" as "thread group", IIUC.  So i1 identify an inferior.  Your suggestion "the number assigned by @value{GDBN} to the inferior" is good to me.
>>
>> In these cases, I'd just go and copy what is written in other similar
>> cases already in the manual.  Should make the end overall result a bit more
>> consistent.  For example, borrowing from the "-add-inferior" command's text,
>> you'd get something like:
>>
>> "The notification has a single field, @samp{thread-group}, whose value is the
>> identifier of the thread group corresponding to the affected inferior."
>>
> 
> How about this?
> 
>  The process record was either started or stopped in thread group
>  @var{id}.  The @var{id} is the identifier of the thread group
>  corresponding to the affected inferior.

Nitpicking at this point, as I think that already conveys the necessary
info.  But, I think "Execution log recording" would sound more natural
than "The process record".  The mention of @var{id} twice looks
redundant, yet disconnected.  So I'd suggest:

Execution log recording was either started or stopped on an
inferior.  The @var{id} is the identifier of the thread group
corresponding to the affected inferior.

Thanks,
-- 
Pedro Alves


  reply	other threads:[~2012-09-14 14:13 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-12  7:16 [PATCH 0/2] Two MI notifications on TSV and process record Yao Qi
2012-09-12  7:16 ` [PATCH 1/2] MI notification on tsv created and deleted Yao Qi
2012-09-12 17:48   ` Eli Zaretskii
2012-09-18 12:19     ` [committed]: " Yao Qi
2012-09-13 20:17   ` Tom Tromey
2012-09-12  7:16 ` [PATCH 2/2] MI notification on record started and stopped Yao Qi
2012-09-12 17:52   ` Eli Zaretskii
2012-09-13  8:57     ` Yao Qi
2012-09-13 17:33       ` Eli Zaretskii
2012-09-14  2:54         ` Yao Qi
2012-09-14  9:49           ` Eli Zaretskii
2012-09-14 11:45             ` Yao Qi
2012-09-14 12:09               ` Pedro Alves
2012-09-14 13:14                 ` Yao Qi
2012-09-14 14:13                   ` Pedro Alves [this message]
2012-09-21  1:47                     ` [committed]: " Yao Qi
2012-09-21  6:58                       ` Regression for gdb.mi/mi-reverse.exp [Re: [committed]: [PATCH 2/2] MI notification on record started and stopped] Jan Kratochvil
2012-09-21  7:26                         ` Yao Qi
2012-09-14 13:30               ` [PATCH 2/2] MI notification on record started and stopped Eli Zaretskii
2012-09-12 18:07   ` Tom Tromey
2012-09-12 19:04     ` Pedro Alves
2012-09-12 19:01   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50533B81.2010009@redhat.com \
    --to=palves@redhat.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox