From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4532 invoked by alias); 14 Sep 2012 14:13:58 -0000 Received: (qmail 4506 invoked by uid 22791); 14 Sep 2012 14:13:55 -0000 X-SWARE-Spam-Status: No, hits=-7.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 14 Sep 2012 14:13:25 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8EEDNla001716 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 14 Sep 2012 10:13:23 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q8EEDLPE031117; Fri, 14 Sep 2012 10:13:22 -0400 Message-ID: <50533B81.2010009@redhat.com> Date: Fri, 14 Sep 2012 14:13:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 MIME-Version: 1.0 To: Yao Qi CC: Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] MI notification on record started and stopped References: <1347434118-10931-1-git-send-email-yao@codesourcery.com> <1347434118-10931-3-git-send-email-yao@codesourcery.com> <838vcfw2my.fsf@gnu.org> <50519FC6.3090704@codesourcery.com> <83r4q5vne6.fsf@gnu.org> <50529C21.5020909@codesourcery.com> <83boh9ue6b.fsf@gnu.org> <505318AD.50603@codesourcery.com> <50531E46.4090708@redhat.com> <50532D6D.5060400@codesourcery.com> In-Reply-To: <50532D6D.5060400@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00285.txt.bz2 On 09/14/2012 02:13 PM, Yao Qi wrote: > On 09/14/2012 08:08 PM, Pedro Alves wrote: >> On 09/14/2012 12:44 PM, Yao Qi wrote: >>> On 09/14/2012 05:49 PM, Eli Zaretskii wrote: >>>>> The notification is like '=record-started,thread-group="i1"'. >>>> ?? If this is a thread-group, why does i1 identify a_process_? Don't >>>> you mean "thread group"? >>> >>> As matter of fact, this is an inferior, but in MI notification, we call "inferior" as "thread group", IIUC. So i1 identify an inferior. Your suggestion "the number assigned by @value{GDBN} to the inferior" is good to me. >> >> In these cases, I'd just go and copy what is written in other similar >> cases already in the manual. Should make the end overall result a bit more >> consistent. For example, borrowing from the "-add-inferior" command's text, >> you'd get something like: >> >> "The notification has a single field, @samp{thread-group}, whose value is the >> identifier of the thread group corresponding to the affected inferior." >> > > How about this? > > The process record was either started or stopped in thread group > @var{id}. The @var{id} is the identifier of the thread group > corresponding to the affected inferior. Nitpicking at this point, as I think that already conveys the necessary info. But, I think "Execution log recording" would sound more natural than "The process record". The mention of @var{id} twice looks redundant, yet disconnected. So I'd suggest: Execution log recording was either started or stopped on an inferior. The @var{id} is the identifier of the thread group corresponding to the affected inferior. Thanks, -- Pedro Alves