From: Pedro Alves <palves@redhat.com>
To: Stan Shebs <stanshebs@earthlink.net>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Merge mi-cli.exp and mi2-cli.exp
Date: Wed, 12 Sep 2012 15:28:00 -0000 [thread overview]
Message-ID: <5050A9D7.9020408@redhat.com> (raw)
In-Reply-To: <504FB2D3.9030108@earthlink.net>
On 09/11/2012 10:53 PM, Stan Shebs wrote:
>> But more than that, in reality, we stopped supporting MI1 almost 10 years ago:
>>
>> http://sourceware.org/ml/gdb-patches/2004-02/msg00352.html
>
> That's a good point, seemed like it was just yesterday. :-) A little poking around the net shows that it's been quite a while since anybody has used MI1.
:-)
>
>> So my opinion is that we revisit the policy a bit, and backtrack a the
>> mi-.*exp vs mi2-.*exp idea, get rid of the duplication, and call everything
>> "MI2", as it is in practice (must be, because that's how we run the tests).
>> When we really introduce an incompatible change that actually justifies MI3,
>> _then_ we should revisit the policy of whether to mass copying/rename tests, or
>> share them, depending on how big the difference between the versions would be,
>> and therefore depending on the practicality of the different options.
>>
>
> Sounds like a fine idea - and MI1 has already been deprecated for a long time, so we can just whack things now.
To be clear, there's no MI1 test in the suite anymore. What we have is
explicit -i=mi2 tests, and -i=mi tests. One of the sets was copied from
the other, with the idea that we'd fork them and while breaking
compatibility with MI2, and that -i=mi would then be switched to mean MI3.
But that never happened. The -i=mi tests still test the same MI2. So we now test
the same things twice, due to the tests having been copied prematurely.
--
Pedro Alves
next prev parent reply other threads:[~2012-09-12 15:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 13:29 Yao Qi
2012-09-03 9:08 ` Vladimir Prus
2012-09-03 15:55 ` Yao Qi
2012-09-05 0:29 ` Stan Shebs
2012-09-10 20:09 ` Tom Tromey
2012-09-11 15:15 ` Pedro Alves
2012-09-11 21:53 ` Stan Shebs
2012-09-12 15:28 ` Pedro Alves [this message]
2012-09-12 13:59 ` Yao Qi
2012-09-19 11:22 ` Yao Qi
2012-09-19 13:47 ` Pedro Alves
2012-09-21 8:40 ` Yao Qi
2012-09-28 0:04 ` [PATCH 0/11] Cleanup MI test cases Yao Qi
2012-09-28 0:04 ` [PATCH 02/11] mi-var-block.exp Yao Qi
2012-09-28 0:04 ` [PATCH 05/11] mi-pthreads.exp Yao Qi
2012-09-28 0:05 ` [PATCH 07/11] mi-var-cmd.exp Yao Qi
2012-09-28 0:05 ` [PATCH 03/11] mi-file.exp Yao Qi
2012-09-28 0:05 ` [PATCH 04/11] mi-basics.exp Yao Qi
2012-09-28 0:05 ` [PATCH 10/11] mi-stack.exp Yao Qi
2012-09-28 0:05 ` [PATCH 08/11] mi-var-display.exp Yao Qi
2012-09-28 0:05 ` [PATCH 09/11] mi-console.exp Yao Qi
2012-09-28 0:05 ` [PATCH 06/11] mi-break.exp Yao Qi
2012-09-28 0:05 ` [PATCH 01/11] Remove mi-FOO.exp which are identical to mi2-FOO.exp Yao Qi
2012-09-28 0:05 ` [PATCH 11/11] mi-syn-frame.exp Yao Qi
2012-09-28 19:36 ` [PATCH 0/11] Cleanup MI test cases Pedro Alves
2012-10-12 9:47 ` Yao Qi
2012-10-12 10:05 ` Pedro Alves
2012-10-14 12:25 ` [committed] : " Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5050A9D7.9020408@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=stanshebs@earthlink.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox