From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4796 invoked by alias); 12 Sep 2012 15:28:22 -0000 Received: (qmail 4763 invoked by uid 22791); 12 Sep 2012 15:28:18 -0000 X-SWARE-Spam-Status: No, hits=-7.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 12 Sep 2012 15:27:53 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8CFRLTp028419 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 12 Sep 2012 11:27:21 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q8CFRKR2003925; Wed, 12 Sep 2012 11:27:20 -0400 Message-ID: <5050A9D7.9020408@redhat.com> Date: Wed, 12 Sep 2012 15:28:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 MIME-Version: 1.0 To: Stan Shebs CC: gdb-patches@sourceware.org Subject: Re: [RFC] Merge mi-cli.exp and mi2-cli.exp References: <1346419770-5718-1-git-send-email-yao@codesourcery.com> <50469CDA.1030406@earthlink.net> <504F5592.6000102@redhat.com> <504FB2D3.9030108@earthlink.net> In-Reply-To: <504FB2D3.9030108@earthlink.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00208.txt.bz2 On 09/11/2012 10:53 PM, Stan Shebs wrote: >> But more than that, in reality, we stopped supporting MI1 almost 10 years ago: >> >> http://sourceware.org/ml/gdb-patches/2004-02/msg00352.html > > That's a good point, seemed like it was just yesterday. :-) A little poking around the net shows that it's been quite a while since anybody has used MI1. :-) > >> So my opinion is that we revisit the policy a bit, and backtrack a the >> mi-.*exp vs mi2-.*exp idea, get rid of the duplication, and call everything >> "MI2", as it is in practice (must be, because that's how we run the tests). >> When we really introduce an incompatible change that actually justifies MI3, >> _then_ we should revisit the policy of whether to mass copying/rename tests, or >> share them, depending on how big the difference between the versions would be, >> and therefore depending on the practicality of the different options. >> > > Sounds like a fine idea - and MI1 has already been deprecated for a long time, so we can just whack things now. To be clear, there's no MI1 test in the suite anymore. What we have is explicit -i=mi2 tests, and -i=mi tests. One of the sets was copied from the other, with the idea that we'd fork them and while breaking compatibility with MI2, and that -i=mi would then be switched to mean MI3. But that never happened. The -i=mi tests still test the same MI2. So we now test the same things twice, due to the tests having been copied prematurely. -- Pedro Alves