From: Phil Muldoon <pmuldoon@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: fix PR 14386
Date: Mon, 06 Aug 2012 09:42:00 -0000 [thread overview]
Message-ID: <501F9173.2040400@redhat.com> (raw)
In-Reply-To: <873946woli.fsf@fleche.redhat.com>
On 08/01/2012 05:42 PM, Tom Tromey wrote:
> This fixes PR python/14386.
>
> I'd like to commit this to the trunk and the 7.5 branch; the latter
> because it is a reasonably obvious, low-risk, and useful bug fix.
>
> The bug here is that a certain libstdc++ pretty-printer doesn't work in
> MI.
Looks great to me. The only comment I have has nothing to do with your
patch, but I will comment here for context.
It seems we wind-up printing two errors if the value returned to
"children" is not an iterator. The "type error" exception that is
printed with gdbpy_print_stack, and then the explicit error call we call
right after. Not sure if this is because of an MI detail needing an
"error" call, but it seems counter-intuitive to print two error
messages for one exception. Maybe in a future patch we could extract
the exception message from the exception and pass that to the GDB
error call, or skip the error call completely.
Cheers,
Phil
next prev parent reply other threads:[~2012-08-06 9:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 18:11 Tom Tromey
2012-08-01 19:29 ` Tom Tromey
2012-08-01 20:31 ` Pedro Alves
2012-08-06 9:42 ` Phil Muldoon [this message]
2012-08-06 18:43 ` Tom Tromey
2012-08-06 19:16 ` Tom Tromey
2012-08-13 18:17 ` Joel Brobecker
2012-08-13 19:44 ` Tom Tromey
2012-08-15 19:50 ` Joel Brobecker
2012-08-16 18:22 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501F9173.2040400@redhat.com \
--to=pmuldoon@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox