From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26877 invoked by alias); 6 Aug 2012 09:42:32 -0000 Received: (qmail 26869 invoked by uid 22791); 6 Aug 2012 09:42:31 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 06 Aug 2012 09:42:14 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q769gDU7011450 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 6 Aug 2012 05:42:13 -0400 Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q769gB59024377; Mon, 6 Aug 2012 05:42:13 -0400 Message-ID: <501F9173.2040400@redhat.com> Date: Mon, 06 Aug 2012 09:42:00 -0000 From: Phil Muldoon MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: RFC: fix PR 14386 References: <873946woli.fsf@fleche.redhat.com> In-Reply-To: <873946woli.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00158.txt.bz2 On 08/01/2012 05:42 PM, Tom Tromey wrote: > This fixes PR python/14386. > > I'd like to commit this to the trunk and the 7.5 branch; the latter > because it is a reasonably obvious, low-risk, and useful bug fix. > > The bug here is that a certain libstdc++ pretty-printer doesn't work in > MI. Looks great to me. The only comment I have has nothing to do with your patch, but I will comment here for context. It seems we wind-up printing two errors if the value returned to "children" is not an iterator. The "type error" exception that is printed with gdbpy_print_stack, and then the explicit error call we call right after. Not sure if this is because of an MI detail needing an "error" call, but it seems counter-intuitive to print two error messages for one exception. Maybe in a future patch we could extract the exception message from the exception and pass that to the GDB error call, or skip the error call completely. Cheers, Phil