* [RFA] Record function name in decode_objc
@ 2012-07-23 18:38 Keith Seitz
2012-07-23 18:57 ` Tom Tromey
0 siblings, 1 reply; 3+ messages in thread
From: Keith Seitz @ 2012-07-23 18:38 UTC (permalink / raw)
To: gp >> "gdb-patches@sourceware.org ml"
[-- Attachment #1: Type: text/plain, Size: 319 bytes --]
Hi,
decode_objc currently does not save the found function name into the
linespec_p. [It saves the found function, but not the string name for it.]
This patch fixes this omission.
Keith
ChangeLog
2012-07-23 Keith Seitz <keiths@redhat.com>
* linespec.c (decode_objc): Record the function name
in the linespec.
[-- Attachment #2: decode_objc-save-function-name.patch --]
[-- Type: text/x-patch, Size: 652 bytes --]
Index: linespec.c
===================================================================
RCS file: /cvs/src/src/gdb/linespec.c,v
retrieving revision 1.162
diff -u -p -r1.162 linespec.c
--- linespec.c 18 Jul 2012 20:38:18 -0000 1.162
+++ linespec.c 18 Jul 2012 21:04:59 -0000
@@ -2477,6 +2477,7 @@ decode_objc (struct linespec_state *self
memcpy (saved_arg, *argptr, new_argptr - *argptr);
saved_arg[new_argptr - *argptr] = '\0';
+ ls->function_name = xstrdup (saved_arg);
ls->function_symbols = info.result.symbols;
ls->minimal_symbols = info.result.minimal_symbols;
values = convert_linespec_to_sals (self, ls);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] Record function name in decode_objc
2012-07-23 18:38 [RFA] Record function name in decode_objc Keith Seitz
@ 2012-07-23 18:57 ` Tom Tromey
2012-07-23 20:32 ` Keith Seitz
0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2012-07-23 18:57 UTC (permalink / raw)
To: Keith Seitz; +Cc: gp >> "gdb-patches@sourceware.org ml"
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Keith> This patch fixes this omission.
Keith> 2012-07-23 Keith Seitz <keiths@redhat.com>
Keith> * linespec.c (decode_objc): Record the function name
Keith> in the linespec.
Ok.
Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] Record function name in decode_objc
2012-07-23 18:57 ` Tom Tromey
@ 2012-07-23 20:32 ` Keith Seitz
0 siblings, 0 replies; 3+ messages in thread
From: Keith Seitz @ 2012-07-23 20:32 UTC (permalink / raw)
Cc: gp >> "gdb-patches@sourceware.org ml"
On 07/23/2012 11:56 AM, Tom Tromey wrote:
>>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
>
> Keith> This patch fixes this omission.
>
> Keith> 2012-07-23 Keith Seitz <keiths@redhat.com>
> Keith> * linespec.c (decode_objc): Record the function name
> Keith> in the linespec.
>
> Ok.
Committed. Thank you, Tom.
Keith
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-23 20:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-23 18:38 [RFA] Record function name in decode_objc Keith Seitz
2012-07-23 18:57 ` Tom Tromey
2012-07-23 20:32 ` Keith Seitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox