* [RFA] Cleanup: Constify parameter for linespec_parse_line_offset
@ 2012-07-17 21:28 Keith Seitz
2012-07-17 21:46 ` Jan Kratochvil
0 siblings, 1 reply; 2+ messages in thread
From: Keith Seitz @ 2012-07-17 21:28 UTC (permalink / raw)
To: gdb-patches@sourceware.org ml
Hi,
The following trivial patch does makes the parameter for
linespec_parse_line_offset const char*.
Ok?
Keith
ChangeLog
2012-07-17 Keith Seitz <keiths@redhat.com>
* linespec.c (linespec_parse_line_offset): Make parameter
const.
diff --git a/gdb/linespec.c b/gdb/linespec.c
index 4156694..e5c1f9f 100644
--- a/gdb/linespec.c
+++ b/gdb/linespec.c
@@ -1420,7 +1420,7 @@ unexpected_linespec_error (linespec_parser *parser)
/* Parse and return a line offset in STRING. */
static struct line_offset
-linespec_parse_line_offset (char *string)
+linespec_parse_line_offset (const char *string)
{
struct line_offset line_offset = {0, LINE_OFFSET_NONE};
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RFA] Cleanup: Constify parameter for linespec_parse_line_offset
2012-07-17 21:28 [RFA] Cleanup: Constify parameter for linespec_parse_line_offset Keith Seitz
@ 2012-07-17 21:46 ` Jan Kratochvil
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kratochvil @ 2012-07-17 21:46 UTC (permalink / raw)
To: Keith Seitz; +Cc: gdb-patches@sourceware.org ml
On Tue, 17 Jul 2012 23:28:38 +0200, Keith Seitz wrote:
> * linespec.c (linespec_parse_line_offset): Make parameter
> const.
Yes, I would find such patch [obv]ious.
Thanks,
Jan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-17 21:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-17 21:28 [RFA] Cleanup: Constify parameter for linespec_parse_line_offset Keith Seitz
2012-07-17 21:46 ` Jan Kratochvil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox