Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Kevin Buettner <kevin@buettner.to>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 3/5] Distinguish sentinel frame from null frame
Date: Wed, 09 Nov 2016 14:48:00 -0000	[thread overview]
Message-ID: <50027813-1980-c776-61e9-0d3a34e3455b@redhat.com> (raw)
In-Reply-To: <20161102151650.644ed9f5@pinnacle.lan>

On 11/02/2016 10:16 PM, Kevin Buettner wrote:

> --- a/gdb/frame.h
> +++ b/gdb/frame.h
> @@ -90,6 +90,9 @@ enum frame_id_stack_status
>    /* Stack address is valid, and is found in the stack_addr field.  */
>    FID_STACK_VALID = 1,
>  
> +  /* Sentinel frame.  Stack may or may not be valid.  */
> +  FID_STACK_SENTINEL = 2,

What does this "Stack may or may not be valid" comment mean?
"sentinel_frame_id" is a constant, how can the "stack_addr" field
vary?

Otherwise LGTM.

Thanks,
Pedro Alves


  parent reply	other threads:[~2016-11-09 14:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-02 22:11 [PATCH v2 0/5] Prevent more recursion in python based unwinders Kevin Buettner
2016-11-02 22:14 ` [PATCH v2 1/5] Extend test gdb.python/py-recurse-unwind.exp Kevin Buettner
2016-11-09 13:59   ` Pedro Alves
2016-11-16 18:52     ` Kevin Buettner
2016-11-16 22:46       ` Sergio Durigan Junior
2016-11-17 15:27         ` Kevin Buettner
2016-11-02 22:16 ` [PATCH v2 3/5] Distinguish sentinel frame from null frame Kevin Buettner
2016-11-02 22:20   ` Kevin Buettner
2016-11-09 14:48   ` Pedro Alves [this message]
2016-11-16 18:54     ` Kevin Buettner
2016-11-02 22:19 ` [PATCH v2 3/5] Change meaning of VALUE_FRAME_ID; rename to VALUE_NEXT_FRAME_ID Kevin Buettner
2016-11-09 14:48   ` Pedro Alves
2016-11-16 19:08     ` Kevin Buettner
2016-11-02 22:23 ` [PATCH v2 4/5] Make gdb.PendingFrame.read_register handle "user" registers Kevin Buettner
2016-11-16 19:08   ` Kevin Buettner
2016-11-02 22:26 ` [PATCH v2 5/5] Stash frame id of current frame before stashing frame id for previous frame Kevin Buettner
2016-11-09 14:48   ` Pedro Alves
2016-11-16 19:07     ` Kevin Buettner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50027813-1980-c776-61e9-0d3a34e3455b@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=kevin@buettner.to \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox