From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10552 invoked by alias); 9 Nov 2016 14:48:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9330 invoked by uid 89); 9 Nov 2016 14:48:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=sk:sentine X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Nov 2016 14:48:20 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 63A1761E7C; Wed, 9 Nov 2016 14:48:11 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uA9Em9XU026994; Wed, 9 Nov 2016 09:48:10 -0500 Subject: Re: [PATCH v2 3/5] Distinguish sentinel frame from null frame To: Kevin Buettner , gdb-patches@sourceware.org References: <20161102151111.2462c806@pinnacle.lan> <20161102151650.644ed9f5@pinnacle.lan> From: Pedro Alves Message-ID: <50027813-1980-c776-61e9-0d3a34e3455b@redhat.com> Date: Wed, 09 Nov 2016 14:48:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20161102151650.644ed9f5@pinnacle.lan> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00215.txt.bz2 On 11/02/2016 10:16 PM, Kevin Buettner wrote: > --- a/gdb/frame.h > +++ b/gdb/frame.h > @@ -90,6 +90,9 @@ enum frame_id_stack_status > /* Stack address is valid, and is found in the stack_addr field. */ > FID_STACK_VALID = 1, > > + /* Sentinel frame. Stack may or may not be valid. */ > + FID_STACK_SENTINEL = 2, What does this "Stack may or may not be valid" comment mean? "sentinel_frame_id" is a constant, how can the "stack_addr" field vary? Otherwise LGTM. Thanks, Pedro Alves