Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
To: Christian Biesinger <cbiesinger@google.com>,
	Tom Tromey <tromey@adacore.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Restore info_command and breakpoint
Date: Tue, 05 May 2020 20:51:22 +0200	[thread overview]
Message-ID: <4ef197e430ae95326ccbf333763c93f5a0ca0646.camel@skynet.be> (raw)
In-Reply-To: <CAPTJ0XHH+FeoDjJTgf6zkU9qJfjwd2aOi+t3_eOSN10=JUsbSQ@mail.gmail.com>

On Tue, 2020-05-05 at 13:26 -0500, Christian Biesinger via Gdb-patches wrote:

> > diff --git a/gdb/gdb-gdb.gdb.in b/gdb/gdb-gdb.gdb.in
> > index b647445e8c9..05a38b2670b 100644
> > --- a/gdb/gdb-gdb.gdb.in
> > +++ b/gdb/gdb-gdb.gdb.in
> > @@ -7,6 +7,12 @@ if !$gdb_init_done
> > 
> >    b internal_error
> > 
> > +  b info_command
> 
> It would probably be good to add a comment here?
> # This provides an easy way to break into the top-level GDB by typing "info"
Yes, good idea.
Even    ... by typing "info" or "i".
Also, a comment to explain the return, something like:
# return to avoid the long output of "info" command list.
as the objective of this was not crystal clear to everybody.
 
> 
> > +  commands
> > +    silent
> > +    return
> > +  end
> > +
> >    dir @srcdir@/../libiberty
> >    dir @srcdir@/../bfd
> >    dir @srcdir@
> > --
> > 2.21.1
> > 



  reply	other threads:[~2020-05-05 18:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-05 17:02 Tom Tromey
2020-05-05 18:26 ` Christian Biesinger
2020-05-05 18:51   ` Philippe Waroquiers [this message]
2020-05-05 19:00     ` Tom Tromey
2020-05-05 19:00   ` Tom Tromey
2020-05-11 21:28 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ef197e430ae95326ccbf333763c93f5a0ca0646.camel@skynet.be \
    --to=philippe.waroquiers@skynet.be \
    --cc=cbiesinger@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox