From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailsec118.isp.belgacom.be (mailsec118.isp.belgacom.be [195.238.20.114]) by sourceware.org (Postfix) with ESMTPS id 77E63389001F for ; Tue, 5 May 2020 18:51:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 77E63389001F IronPort-SDR: VhJ5XifJQvidgDSq8rswRAHALyIs9C7fjuhRJZZwSKdqE5eoP8Ibz6cmPKfplalthYoGND/ce2 5/C6exjqZyvCOygWD9GU/6r/8nWwi8pD1FX3vg4EnEDOQjcZWlYTtHF1J7cSzWHPrN4s29192S c34EfGfwsGTDotXH9Sm7GGuItmfrJ96ydxOWeCimhUKmIKI4EVvg3735ucC3ze+ehQ/edN0BIu zm8KrnhvqPZNQk4lNBA+C28bBFuX8ui6GibmMKZp0ZukHQ0Z7ejlr73NQQosEXYnGSwV3dFIPc rFk= IronPort-PHdr: =?us-ascii?q?9a23=3ASuVPXRAOadVDOJ9S4B4WUyQJP3N1i/DPJgcQr6?= =?us-ascii?q?AfoPdwSP37rs+wAkXT6L1XgUPTWs2DsrQY0reQ7P6rADZcqb+681k6OKRWUB?= =?us-ascii?q?EEjchE1ycBO+WiTXPBEfjxciYhF95DXlI2t1uyMExSBdqsLwaK+i764jEdAA?= =?us-ascii?q?jwOhRoLerpBIHSk9631+ev8JHPfglEnjWwba5yIRmsrwjct8YajZZ8Jqs+1x?= =?us-ascii?q?DEvmZGd+NKyG1yOFmdhQz85sC+/J5i9yRfpfcs/NNeXKv5Yqo1U6VWACwpPG?= =?us-ascii?q?4p6sLrswLDTRaU6XsHTmoWiBtIDBPb4xz8Q5z8rzH1tut52CmdIM32UbU5Ui?= =?us-ascii?q?ms4qt3VBPljjoMOiUn+2/LlMN/kKNboAqgpxNhxY7UfJqVP+d6cq/EYN8WWX?= =?us-ascii?q?ZNUsNXWidcAI2zcpEPAvICM+hFr4fzuVUAohmwBQawCuzgxTBGi2Tq3aA4ye?= =?us-ascii?q?ktDR3K0RYiEt8IrX/arM/1NKAXUe2t1qfIzTTDb/dX2Tfl8IjHbA0qrvGWUr?= =?us-ascii?q?JqdsrR0FQvFwLbgVWKsozuIjSY1vwNs2ia6+pgVPqvi3Y5pA1rrDmg3N0sio?= =?us-ascii?q?7QhoIIy1DL6z95wJ0uKN2jS056YdikH4VMty2ALIR5XNovTmd1syk11rMIo4?= =?us-ascii?q?S0fDQWyJs53R7fbeSKfouH7x//WuicLyl0iXJ5db+jhBu//kqtx/HiWsS20F?= =?us-ascii?q?tHoCVLnsfDuHwR1xHe6cqKRPt880qv2juC2AHe5OFYLE0yiKHVJZkhwrsqmZ?= =?us-ascii?q?oSt0TOBiD2l1jtg6OMd0Uk/O6l4PnkbLX+vpKQKZJ4hwPkPqgzlMGyAP40Pw?= =?us-ascii?q?sTU2SB9+mx2rvu9lDjTrpQlP05iKzZvYjfJcQcu6G2HRdY0p0m6xajFzem18?= =?us-ascii?q?kYnWUfIFJFZh2Hi4/pNknLIP/lFfu/glKsnyl3x/3eILHtH5fAImLenLrvfL?= =?us-ascii?q?tx8U1RxBcpwd1R6Z9YErQBL+jyWk/1utzYFBg5Mwmszub/CNV914ceWWOXAq?= =?us-ascii?q?+BLqzeq1GJ6fg1I+mLfY8VpTf9JOY/5/71lnI5glwdfKmv3ZQJdHC0BO9pLF?= =?us-ascii?q?uBbXr2ntgBCXsKvhY5TOHylFKNSj9TaGipX6I94DE7B5ypDZ3YS4Cih7yB2y?= =?us-ascii?q?i7HplIaWxcFl+MFnLofZ2eW/gQcCKSPtNhkjscWLi9UY8h0hSuuxH6yrd8NO?= =?us-ascii?q?Xb5zcXuo7k1Nhv+eLfjw099TtxD86FyWGCU3l0nn8URz8xxK1/rlFyxUya3a?= =?us-ascii?q?hgmfNYCcBc5/NXXQchLpPc1Ot6C83oWg3dYNiIRkypQs+4Dj0rSdIx2dAOMA?= =?us-ascii?q?5BHICJjgrCxDarCrldvb2GH50y/a/Glyz6Lcdw0HfA26Q7p1YhRcRLOCutga?= =?us-ascii?q?sps0DvAIuBr1+ekqu7PfAAxinI+XarxGaHt0ZCXUh7VqCTDl4FYU6DldT44k?= =?us-ascii?q?LaV7LmNr09NRJcyMOYMeMect3oiVReXPqlJ93EZHusmmqqHj6TxaKKYZascW?= =?us-ascii?q?hLj3aVM1QNjw1GpSXODgM5HCr05juGVDE=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2DtAwAWtbFe/yFRiNlmHAEBAQEBAQc?= =?us-ascii?q?BARIBAQQEAQFAgUeCKipEdRIqhCOJAYgOm14LAQEBAQEBAQEBCBsRAQIEAQG?= =?us-ascii?q?ERAKBeyc4EwIDAQEBAwIFAQEGAQEBAQEBBAQBbAQBAQcKhFEhAQMBAQUKAQs?= =?us-ascii?q?IJAyCOykBgw0BBAEjMyMQCAMODAImAgJXBgGDOYJcJLQTgTKFUYMzgUCBDiq?= =?us-ascii?q?MU4FMP4QhPodggmAEjhuKb5lHB4JLfwSHFY9+HZ0gLY9qnUSBaSKBVm1Tgmk?= =?us-ascii?q?JRyWDXJMuiAJCMDcCBggBAQMJdAgTkTcBAQ?= X-IPAS-Result: =?us-ascii?q?A2DtAwAWtbFe/yFRiNlmHAEBAQEBAQcBARIBAQQEAQFAg?= =?us-ascii?q?UeCKipEdRIqhCOJAYgOm14LAQEBAQEBAQEBCBsRAQIEAQGERAKBeyc4EwIDA?= =?us-ascii?q?QEBAwIFAQEGAQEBAQEBBAQBbAQBAQcKhFEhAQMBAQUKAQsIJAyCOykBgw0BB?= =?us-ascii?q?AEjMyMQCAMODAImAgJXBgGDOYJcJLQTgTKFUYMzgUCBDiqMU4FMP4QhPodgg?= =?us-ascii?q?mAEjhuKb5lHB4JLfwSHFY9+HZ0gLY9qnUSBaSKBVm1TgmkJRyWDXJMuiAJCM?= =?us-ascii?q?DcCBggBAQMJdAgTkTcBAQ?= Received: from 33.81-136-217.adsl-dyn.isp.belgacom.be (HELO md) ([217.136.81.33]) by relay.skynet.be with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 May 2020 20:51:22 +0200 Message-ID: <4ef197e430ae95326ccbf333763c93f5a0ca0646.camel@skynet.be> Subject: Re: [PATCH] Restore info_command and breakpoint From: Philippe Waroquiers To: Christian Biesinger , Tom Tromey Cc: gdb-patches Date: Tue, 05 May 2020 20:51:22 +0200 In-Reply-To: References: <20200505170249.31630-1-tromey@adacore.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-14.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 May 2020 18:51:35 -0000 On Tue, 2020-05-05 at 13:26 -0500, Christian Biesinger via Gdb-patches wrote: > > diff --git a/gdb/gdb-gdb.gdb.in b/gdb/gdb-gdb.gdb.in > > index b647445e8c9..05a38b2670b 100644 > > --- a/gdb/gdb-gdb.gdb.in > > +++ b/gdb/gdb-gdb.gdb.in > > @@ -7,6 +7,12 @@ if !$gdb_init_done > > > > b internal_error > > > > + b info_command > > It would probably be good to add a comment here? > # This provides an easy way to break into the top-level GDB by typing "info" Yes, good idea. Even ... by typing "info" or "i". Also, a comment to explain the return, something like: # return to avoid the long output of "info" command list. as the objective of this was not crystal clear to everybody. > > > + commands > > + silent > > + return > > + end > > + > > dir @srcdir@/../libiberty > > dir @srcdir@/../bfd > > dir @srcdir@ > > -- > > 2.21.1 > >