From: Keith Seitz <keiths@redhat.com>
To: Dragorn421 <dragorn421@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v3 1/2] Fix `add-symbol-file -o ... -s ...` address mapping bug
Date: Thu, 24 Sep 2026 11:54:28 -0700 [thread overview]
Message-ID: <4e94fb53-27dd-4f1f-8c46-2b6e5855b269@redhat.com> (raw)
In-Reply-To: <20260924035202.4533-2-dragorn421@gmail.com>
Hi,
Thank you for the revision. This looks good, I just note one
tiny nit.
On 9/23/26 8:51 PM, Dragorn421 wrote:
> diff --git a/gdb/symfile.c b/gdb/symfile.c
> index 017f7a49d8d..5691c2a46d9 100644
> --- a/gdb/symfile.c
> +++ b/gdb/symfile.c
> @@ -2163,7 +2163,7 @@ set_objfile_default_section_offset (struct objfile *objf,
> }
>
> if (cmp == 0)
> - offsets[objf_sect->sectindex] = 0;
> + offsets[objf_sect->sectindex] = objf->section_offsets[objf_sect->sectindex];
This line is now too long. Suggest moving "= ..." to the next line as
per our usual coding convention. No need to repost this patch.
Reviewed-By: Keith Seitz <keiths@redhat.com>
Keith
> }
>
> /* Apply the new section offsets. */
next prev parent reply other threads:[~2026-09-24 18:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 3:51 [PATCH v3 0/2] " Dragorn421
2026-09-24 3:51 ` [PATCH v3 1/2] " Dragorn421
2026-09-24 18:54 ` Keith Seitz [this message]
2026-09-25 7:15 ` Dragorn421
2026-09-25 17:06 ` Keith Seitz
2026-09-24 3:51 ` [PATCH v3 2/2] `add-symbol-file`: add test for mixing -o and -s Dragorn421
2026-09-24 18:57 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e94fb53-27dd-4f1f-8c46-2b6e5855b269@redhat.com \
--to=keiths@redhat.com \
--cc=dragorn421@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox