From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 76E5FwNytWqWJz4AWB0awg (envelope-from ) for ; Thu, 24 Sep 2026 14:54:59 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Ddg0S4Pg; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4E6511E01F; Thu, 24 Sep 2026 14:54:59 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9C6391E01F for ; Thu, 24 Sep 2026 14:54:58 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BABE14BB58B9 for ; Thu, 24 Sep 2026 18:54:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BABE14BB58B9 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Ddg0S4Pg Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id E65F14BB58AB for ; Thu, 24 Sep 2026 18:54:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E65F14BB58AB Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E65F14BB58AB Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790276074; cv=none; b=nKlmHpAm30FAmEl082ClTaWwmUAGW8DC598b1aGBOSwaHRh0Aj70PbKafBj4FPgI5ClZiBq81PmQIHNbw8JEvW1pnfn2kR4hDZI2usAQSi9HAGfhunFj2gsAiSd3DnFZ9NvCuGIlnawnU7JzxcKkKOFuOtAammTFamI6oeJGhDs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790276074; c=relaxed/simple; bh=z9JlT17pGIYrv182Il0BbWlWqpBXsTDHfgrzJunJmXI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=gmSK5RqLcCf/nn4nCbPzrzk+eVT3bPLfupkJHPTI+phDKdv2f59iKCnDaBjSHxFLuoIHkq6qmJw+1uYOiD2ylFauteEut0dIkFjP45MerrkSIAHPbq+VPixmnD4pEFlfpyHVEy8kJQck1Spq0cKN/VHI3nRmuGrEu2mHdVNIPqE= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Ddg0S4Pg DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E65F14BB58AB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790276073; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0jVfa6s0zyFkDH5DM4H+rbC/t6gbfwgl4+ZQpI6w1AE=; b=Ddg0S4PgpqFfLn1efLjCrF2FTak5o5rmnHwEW13TcD20SQiMqHyJi05MGsXqSuHxdr2Qs/ io/y07/g21PJbH2NLHy8U+TzWeEdSp4jVDktGNCVzaA3YFEjlHBdxuDYxoofX1G7lmnwX+ Ji8a2wGahYENVGeNY0RSC2tHsP6WnhE= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-441-9l9nNgicOCO7gvK9RmTZkg-1; Thu, 24 Sep 2026 14:54:32 -0400 X-MC-Unique: 9l9nNgicOCO7gvK9RmTZkg-1 X-Mimecast-MFC-AGG-ID: 9l9nNgicOCO7gvK9RmTZkg_1790276071 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-9104ba8bf51so3697346d6.3 for ; Thu, 24 Sep 2026 11:54:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790276071; x=1790880871; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0jVfa6s0zyFkDH5DM4H+rbC/t6gbfwgl4+ZQpI6w1AE=; b=fKwo6+A/x3uovBBwLReZPWBYv/f30nP09bwZpGF/u7Dt1fHv1+zwivhal5Tqlhtx/5 ojHcFWY+7OLah+qf5SG+/EXZmYYRsOMpIiay+tg2YjTk3I7WLeAvyVpf/1LoQcC74d2M UT9Ud8EklkfjsuejnQB2wafwe7CXm+RWM1K8O1IEgj/MPudxAuR7DFUUVfIB6lCaHDq4 X6yiNhoJ4LFrXrLYvhl8sd++t3UHHdJoJQ2DSMTaEuZMkT00JiJGcSJL75o/7ivSywKb /TD1+mOxQ2GjcwiAtDsURsZU7BMSIrF823sV9xo363I2LlPotLBaDMnWqPGaQti51dLV ZjNw== X-Forwarded-Encrypted: i=1; AKwUvBwkM9JpbRuPmfS7o/zJgPtHMgq1P7BxeZ/78rXyTc0qPKHMAVX54905UWiMfgJuT5aCGuhjyDZ2Ilg+uw==@sourceware.org X-Gm-Message-State: AFuF++kGPsH4n8wIiEhgMIQCy4LaqQYWTm4/lucwaPJk9BnjOweQCuar I9TVOXMHyBngTWWae4QdWJeYRSmumXzvSvOZNZYHHGQT0rCx6tzAqzNBcu3s4/z0uCKp/OW9GG8 1cgqtXQdEI+fAFOi6eoTSJ+mCUWC4qF/6qT+1uaJzhx5ERepb2hcyTCImgQ0uw/8= X-Gm-Gg: AYBFou2vYb0lGEatbVlokfM33qfldt8aAwcm3yYp/ABiccsn9+/QCt127L20CmYoe4t M8jqGsAFxI7sOzqzQ0lqwb0UkuCI5c8R/vx7vpACtoPUwMRJMk+X/Lm43/m5p8ntBMm7pTtBxvs iC4lsPcHEmiofXqMQE52Vblef8Mjf5jdqZWXrT/NuIgk/Fb/GdGhd7jZauG27RfTyk87qCPdPZF fwmyXmyyD+cnUgQexZUvVf5veTwbgg/EKusVGEVTpihTtfwbsBbsoVTGuRh0tsB3N8zkrL6e+rX CKK7YHP+/+N8OoMkeXcWnpE+TydKZVJsu4Zm10j3euyFmaCLNlRdyJAL8zK6PhnPv6/bIwSI7eH bdizYlXE= X-Received: by 2002:a05:6214:598e:b0:910:3452:d57f with SMTP id 6a1803df08f44-9142f8bc3b5mr3125986d6.31.1790276071446; Thu, 24 Sep 2026 11:54:31 -0700 (PDT) X-Received: by 2002:a05:6214:598e:b0:910:3452:d57f with SMTP id 6a1803df08f44-9142f8bc3b5mr3125536d6.31.1790276070992; Thu, 24 Sep 2026 11:54:30 -0700 (PDT) Received: from [150.1.200.157] ([172.56.108.234]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-91430da9123sm170626d6.16.2026.09.24.11.54.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Sep 2026 11:54:30 -0700 (PDT) Message-ID: <4e94fb53-27dd-4f1f-8c46-2b6e5855b269@redhat.com> Date: Thu, 24 Sep 2026 11:54:28 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] Fix `add-symbol-file -o ... -s ...` address mapping bug To: Dragorn421 , gdb-patches@sourceware.org References: <20260924035202.4533-1-dragorn421@gmail.com> <20260924035202.4533-2-dragorn421@gmail.com> From: Keith Seitz In-Reply-To: <20260924035202.4533-2-dragorn421@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: CtztydW0PgOPU85iwaVJyv94hTzXNKSC0kKP6Ik3f6I_1790276071 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi, Thank you for the revision. This looks good, I just note one tiny nit. On 9/23/26 8:51 PM, Dragorn421 wrote: > diff --git a/gdb/symfile.c b/gdb/symfile.c > index 017f7a49d8d..5691c2a46d9 100644 > --- a/gdb/symfile.c > +++ b/gdb/symfile.c > @@ -2163,7 +2163,7 @@ set_objfile_default_section_offset (struct objfile *objf, > } > > if (cmp == 0) > - offsets[objf_sect->sectindex] = 0; > + offsets[objf_sect->sectindex] = objf->section_offsets[objf_sect->sectindex]; This line is now too long. Suggest moving "= ..." to the next line as per our usual coding convention. No need to repost this patch. Reviewed-By: Keith Seitz Keith > } > > /* Apply the new section offsets. */