From: Pedro Alves <palves@redhat.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: Document vMustReplyEmpty remote packet
Date: Wed, 17 May 2017 12:48:00 -0000 [thread overview]
Message-ID: <4e08a83f-59cb-09fb-1934-0a8f555b4808@redhat.com> (raw)
In-Reply-To: <1494840778-18726-1-git-send-email-andrew.burgess@embecosm.com>
On 05/15/2017 10:32 AM, Andrew Burgess wrote:
> Add mention of the vMustReplyEmpty to the remote serial protocol
> documentation. It is important that this packet be treated in the same
> fashion as any other unknown 'v' packet, and I have tried to reflect
> this in the description of the packet, it is not simply the case that we
> _must_ return the empty string for this packet.
>
> As the intention is that we should treat this packet as unknown then an
> argument could be made that we should not document it, however, for
> someone implementing a gdbserver from scratch, seeing an undocumented
> packet arrive from gdb is confusing, and will probably cause them to
> have to read the code in order to check how this packet should be
> handled, which is not ideal.
>
> gdb/doc/ChangeLog:
>
> * gdb.texinfo (Packets): Document vMustReplyEmpty packet.
This is fine with me.
Thanks,
Pedro Alves
prev parent reply other threads:[~2017-05-17 12:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 9:33 Andrew Burgess
2017-05-15 19:13 ` Eli Zaretskii
2017-05-22 19:34 ` Andrew Burgess
2017-05-17 12:48 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e08a83f-59cb-09fb-1934-0a8f555b4808@redhat.com \
--to=palves@redhat.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox