From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85832 invoked by alias); 17 May 2017 12:48:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 74983 invoked by uid 89); 17 May 2017 12:48:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:956 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 17 May 2017 12:48:01 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 83AFF61BA6; Wed, 17 May 2017 12:48:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 83AFF61BA6 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 83AFF61BA6 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8AD11189E2; Wed, 17 May 2017 12:48:02 +0000 (UTC) Subject: Re: [PATCH] gdb: Document vMustReplyEmpty remote packet To: Andrew Burgess , gdb-patches@sourceware.org References: <1494840778-18726-1-git-send-email-andrew.burgess@embecosm.com> From: Pedro Alves Message-ID: <4e08a83f-59cb-09fb-1934-0a8f555b4808@redhat.com> Date: Wed, 17 May 2017 12:48:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1494840778-18726-1-git-send-email-andrew.burgess@embecosm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-05/txt/msg00384.txt.bz2 On 05/15/2017 10:32 AM, Andrew Burgess wrote: > Add mention of the vMustReplyEmpty to the remote serial protocol > documentation. It is important that this packet be treated in the same > fashion as any other unknown 'v' packet, and I have tried to reflect > this in the description of the packet, it is not simply the case that we > _must_ return the empty string for this packet. > > As the intention is that we should treat this packet as unknown then an > argument could be made that we should not document it, however, for > someone implementing a gdbserver from scratch, seeing an undocumented > packet arrive from gdb is confusing, and will probably cause them to > have to read the code in order to check how this packet should be > handled, which is not ideal. > > gdb/doc/ChangeLog: > > * gdb.texinfo (Packets): Document vMustReplyEmpty packet. This is fine with me. Thanks, Pedro Alves