From: Simon Marchi <simark@simark.ca>
To: Christian Biesinger <cbiesinger@google.com>
Cc: Christian Biesinger via gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2] Make GDB compile with Python 3 on MinGW
Date: Thu, 15 Aug 2019 18:25:00 -0000 [thread overview]
Message-ID: <4da44972-0cf2-5871-6da8-079f9bef325c@simark.ca> (raw)
In-Reply-To: <CAPTJ0XE8AxVhkkJ-J+-hQEE=Q0dj-brxXBsaeZqqDvejtJ5Oxw@mail.gmail.com>
On 2019-08-15 1:14 p.m., Christian Biesinger wrote:
>> I don't think PyErr_PrintEx clears the Python error indicator, and I think we want
>> it cleared when we exit this function, so should we call PyErr_Clear here?
>
> It does, per https://docs.python.org/3/c-api/exceptions.html and
> https://docs.python.org/2/c-api/exceptions.html
Ah yeah, I'm blond: "and clear the error indicator".
Simon
prev parent reply other threads:[~2019-08-15 18:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 0:05 [PATCH] " Christian Biesinger via gdb-patches
2019-08-14 16:06 ` [PATCH v2] " Christian Biesinger via gdb-patches
2019-08-15 2:58 ` Simon Marchi
2019-08-15 17:15 ` Christian Biesinger via gdb-patches
2019-08-15 17:15 ` [PATCH] " Christian Biesinger via gdb-patches
2019-08-15 17:42 ` [PATCH v3] " Christian Biesinger via gdb-patches
2019-08-15 18:02 ` Pedro Alves
2019-08-15 18:50 ` Christian Biesinger via gdb-patches
2019-08-15 18:49 ` [PATCH v4] " Christian Biesinger via gdb-patches
2019-08-22 20:48 ` [PING] " Christian Biesinger via gdb-patches
2019-08-22 22:24 ` Simon Marchi
2019-08-22 22:48 ` Christian Biesinger via gdb-patches
2019-09-14 13:09 ` Christian Biesinger via gdb-patches
2019-09-14 13:30 ` Eli Zaretskii
2019-09-14 20:43 ` [PATCH] Add a NEWS entry that gdb can be compiled with py3 on Windows Christian Biesinger via gdb-patches
2019-09-15 2:34 ` Eli Zaretskii
2019-09-15 2:42 ` Christian Biesinger via gdb-patches
2019-08-15 18:25 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4da44972-0cf2-5871-6da8-079f9bef325c@simark.ca \
--to=simark@simark.ca \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox