From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28720 invoked by alias); 15 Aug 2019 18:25:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28571 invoked by uid 89); 15 Aug 2019 18:25:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 Aug 2019 18:25:11 +0000 Received: from [172.16.0.120] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id E3BC41EAAE; Thu, 15 Aug 2019 14:25:09 -0400 (EDT) Subject: Re: [PATCH v2] Make GDB compile with Python 3 on MinGW To: Christian Biesinger Cc: Christian Biesinger via gdb-patches References: <20190814000511.140810-1-cbiesinger@google.com> <20190814160611.104374-1-cbiesinger@google.com> <7c69bd9a-8fc3-f82b-4e68-57788151fb16@simark.ca> From: Simon Marchi Message-ID: <4da44972-0cf2-5871-6da8-079f9bef325c@simark.ca> Date: Thu, 15 Aug 2019 18:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-08/txt/msg00343.txt.bz2 On 2019-08-15 1:14 p.m., Christian Biesinger wrote: >> I don't think PyErr_PrintEx clears the Python error indicator, and I think we want >> it cleared when we exit this function, so should we call PyErr_Clear here? > > It does, per https://docs.python.org/3/c-api/exceptions.html and > https://docs.python.org/2/c-api/exceptions.html Ah yeah, I'm blond: "and clear the error indicator". Simon