Re: [PATCH 2/2] [gdb/testsuite] Use try instead of catch

[Keith Seitz <keiths@redhat.com>]

Hi,

On 9/25/26 7:01 AM, Tom de Vries wrote:
> Use try instead of catch in a few places in lib/gdb.exp.

I think this series looks good, but I did want to point out
one little thing.

> ---
>   gdb/testsuite/lib/gdb.exp | 230 +++++++++++++++++++++++---------------
>   1 file changed, 139 insertions(+), 91 deletions(-)
> 
> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
> index 2cfdbdda09d..3496ddd4132 100644
> --- a/gdb/testsuite/lib/gdb.exp
> +++ b/gdb/testsuite/lib/gdb.exp
> @@ -12380,7 +12425,10 @@ gdb_caching_proc have_startup_shell {} {
>   
>   proc dwz_version { } {
>       set dwz_program "dwz"
> -    set res [catch {exec $dwz_program --version} output]
> +    try {
> +	set output [exec $dwz_program --version]
> +    } trap CHILDSTATUS {output} {
> +    }
>   
>       # Don't check the exit value of 'dwz' process as 'dwz' doesn't
>       # exit immediately after displaying the version number, and for

This is a subtle behavioral change. In the case where dwz does not exist
on the system, `dwz_version' used to return {}. With this change, it now
will propogate an error. IIUC this will cause issues with any test on
such a host that does "require dwz_version N". That will now issue an
error instead of eliciting the usual UNSUPPORTED from dejagnu.

Reviewed-By: Keith Seitz <keiths@redhat.com>

Keith