From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0ulUDT4c2mr7ZAsAWB0awg (envelope-from ) for ; Thu, 22 Oct 2026 10:22:54 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PTgxl8E0; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1E50E378002; Thu, 22 Oct 2026 10:22:54 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8D306378002 for ; Thu, 22 Oct 2026 10:22:53 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CEC434BA23EA for ; Thu, 22 Oct 2026 14:22:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CEC434BA23EA Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PTgxl8E0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 465894BA2E1A for ; Thu, 22 Oct 2026 14:22:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 465894BA2E1A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 465894BA2E1A Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792678947; cv=none; b=HOLncX7g3+kvOCyshFZ4IsOQgxiue/2TzNLTUK7esidZJazAJwPLV/KCkacIYowClbLg0y9nOPpDwJYtrH18Z34tt1nK7qciGcoxw7x0B4nalH+rYn/5LqzTy2OMm/W+j65RBL0NJ7Gk/6ahy78ZGEAi422FrjXCbmhbk3mZm/s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792678947; c=relaxed/simple; bh=xMdu1L4fcTHSfv0iF5J28ez84PJn482HiYu4m8YWt3I=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=OG6v+6D2ZT/XeIJ/wIPgIxxHWcoBHLs0IlMMDSX6TGRPQ7ozzZ+p62nC7dC3siL1UbwY4QtkcDIv2Mxl/koQnjHuabTA359hsFzGY7SLcYvWFPHZ+WxEWzCFBxZQXlRcAjs5t7aJRQNwTB5bvxPcajHXzFxe0Jl9FA7Dvo03EDM= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PTgxl8E0 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 465894BA2E1A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792678946; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+/78xXQN3S72WLktskEujKKa1AibrhD2jEjR6b4795g=; b=PTgxl8E0WmGFcMnW0HQUPxFEl2JZ19VRaf7XhqJh7sVQkymQEteBdRFsOK40aalY9cOf2D 5YsluO0ujVJjC6m52A0Pcz2WLJK5wRmPzxq9LTXsqTX+3tM/UTNhflAxdEcEcgd96W7DW5 DWs7tVrzYnHQ4Z1DvgyCAXLeVYDRfB8= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-696-PYIS9x2aO42pwJLgGPUQDg-1; Thu, 22 Oct 2026 10:22:25 -0400 X-MC-Unique: PYIS9x2aO42pwJLgGPUQDg-1 X-Mimecast-MFC-AGG-ID: PYIS9x2aO42pwJLgGPUQDg_1792678944 Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-3ac16335199so1650378a91.1 for ; Thu, 22 Oct 2026 07:22:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792678944; x=1793283744; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+/78xXQN3S72WLktskEujKKa1AibrhD2jEjR6b4795g=; b=iucrHpgtzRK/yV03XNveYiFqNVT5uRmrs59sx1olzu7rfxyC+cozaErBO+CA2GKyIr Mkkn4NPevl3lSu5SmZRYGWe0vq92aUA7EryHznrsiEboB7grcIY1YWhIP0lUrifEnds6 lzmIwAUpUh13EuFxFQ5qHoum0EUKdkShRjiJ7zpfFsQb0sSQFyWPvN5CKSvRUhvd19bT qusKuZ+osI3rpY9M9OuGzl7rhK0T4Ii3/5zYLeNdVXDOJqCAc4uoTyL+6ZV7bvKdqrw9 XGAqW+Cft4RDS+Ff5xSRQJ2KQQVLA5XJgA2I1vt35vD5EemmzU2pBBacobFBsbGV1Jxu VPcg== X-Forwarded-Encrypted: i=1; AKwUvByGspjK/DJs5zbAuvIiXukLWfmRhbVdQtR9if8Skx6402axY7jq2NXl0F6QYCtGNQFv4CxcuESbecA10g==@sourceware.org X-Gm-Message-State: AFq9FYLBDw6j/WvY2AWFb41g5/w6tcEi6QtqpbZV+DRZb/OyTi3a8/+P +rBZw7yXdbaMVuyjcXndSI7juNbOSBUacVYzSJ+Rs309UNAGqr+sOIHv8hRvf/1UuMWlQCUrXjN sFKXxITcshO2eGl1bYVjS9FhaiqvWOydUvXG07tHF8PJGHSYUELELxIHjnIwu3bM= X-Gm-Gg: AYBFou30CnCkKPRrL+kxiRkdq7hBAgv8RtkAfUXzAljA2plg7uDkSmUCcS6p8GzvHN3 Zs0XEZjWXPnzov3IeP1yWYhi8+MaxtA72Ti264wbsrf/MI5vJ/hs8iCSVbZVILFlqq0m28MDpmA YocMx/ChHcC6c2r8B2vz+rDZeGy6aCT29sQ+AqaPOB1rRwcVBAmeu/CnNBlnGxhJhEPS1npixeO kk3R9TPtUbuERpwgCHUtVv1uj4qieW/B87H6njBIqvq6IoQwYD0MXUeeOfJIT1kV15PazmaAB69 cZoQF7lhO/NOaJ0UIMOL+mFG4LzOP3P/M4zRtZZB0UyhJTDJwKQje3/6yYKAQv47SzSMgwIp+g8 mTe+R0g== X-Received: by 2002:a17:90b:4a47:b0:3a8:9db2:a4f with SMTP id 98e67ed59e1d1-3ad86d393c4mr4691085a91.51.1792678943728; Thu, 22 Oct 2026 07:22:23 -0700 (PDT) X-Received: by 2002:a17:90b:4a47:b0:3a8:9db2:a4f with SMTP id 98e67ed59e1d1-3ad86d393c4mr4691060a91.51.1792678943006; Thu, 22 Oct 2026 07:22:23 -0700 (PDT) Received: from [150.1.200.157] ([172.56.105.42]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ada4896c4dsm4515969a91.7.2026.10.22.07.22.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Oct 2026 07:22:21 -0700 (PDT) Message-ID: <4d525a62-ba57-48fa-8bfa-7840c575a425@redhat.com> Date: Thu, 22 Oct 2026 07:22:20 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] [gdb/testsuite] Use try instead of catch To: Tom de Vries , gdb-patches@sourceware.org References: <20260925140116.1985238-1-tdevries@suse.de> <20260925140116.1985238-3-tdevries@suse.de> From: Keith Seitz In-Reply-To: <20260925140116.1985238-3-tdevries@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: d0RQxNT0-mS-sifIg2VKYTdcpAT3D7vJuIsgL_Dny3s_1792678944 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi, On 9/25/26 7:01 AM, Tom de Vries wrote: > Use try instead of catch in a few places in lib/gdb.exp. I think this series looks good, but I did want to point out one little thing. > --- > gdb/testsuite/lib/gdb.exp | 230 +++++++++++++++++++++++--------------- > 1 file changed, 139 insertions(+), 91 deletions(-) > > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index 2cfdbdda09d..3496ddd4132 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -12380,7 +12425,10 @@ gdb_caching_proc have_startup_shell {} { > > proc dwz_version { } { > set dwz_program "dwz" > - set res [catch {exec $dwz_program --version} output] > + try { > + set output [exec $dwz_program --version] > + } trap CHILDSTATUS {output} { > + } > > # Don't check the exit value of 'dwz' process as 'dwz' doesn't > # exit immediately after displaying the version number, and for This is a subtle behavioral change. In the case where dwz does not exist on the system, `dwz_version' used to return {}. With this change, it now will propogate an error. IIUC this will cause issues with any test on such a host that does "require dwz_version N". That will now issue an error instead of eliciting the usual UNSUPPORTED from dejagnu. Reviewed-By: Keith Seitz Keith