Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Lancelot SIX via Gdb-patches <gdb-patches@sourceware.org>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Cc: lsix@lancelotsix.com
Subject: Re: [PATCH 3/3] gdb/varobj: Only re-evaluate invalid globals during re_set
Date: Thu, 11 Aug 2022 15:07:07 +0100	[thread overview]
Message-ID: <4b46dde7-b1d6-da32-fe47-934f0046e72a@amd.com> (raw)
In-Reply-To: <f7b3e95e-5751-f52f-59d2-9fc73efe8986@suse.de>

On 09/08/2022 11:55, Tom de Vries wrote:
> [CAUTION: External Email]
> 
> On 8/4/22 15:02, Lancelot SIX wrote:
>> When doing varobj_re_set, we currently try to recreate floating varobj.
>> This was introduced by 4e969b4f0128 "Re-evaluate floating varobj as part
>> of varobj_invalidate" to deal with use a after free issue.  However
>> since bc20e562ec0 "Fix use after free in varobj" we now ensure that we
>> never have dangling pointers so this all recreation is not strictly
>> needed anymore for floating varobjs.
>>
>> This commit proposes to remove this recreation process for floating
>> varobjs.
>>
>> Tested on x86_64-linux.
> 
> LGTM.
> 
> Thanks,
> - Tom
Hi,

Thanks.

I have done the changes you asked in patch #1 locally.  I am about to 
push the series.

Best,
Lanceolt.

      reply	other threads:[~2022-08-11 14:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-04 13:02 [PATCH 0/3] Varobj re_set clanup Lancelot SIX via Gdb-patches
2022-08-04 13:02 ` [PATCH 1/3] gdb/varobj: Do not invalidate locals in varobj_invalidate_iter Lancelot SIX via Gdb-patches
2022-08-05 15:03   ` Tom de Vries via Gdb-patches
2022-08-04 13:02 ` [PATCH 2/3] gdb/varobj: Reset varobj after relocations have been computed Lancelot SIX via Gdb-patches
2022-08-09 10:55   ` Tom de Vries via Gdb-patches
2022-08-04 13:02 ` [PATCH 3/3] gdb/varobj: Only re-evaluate invalid globals during re_set Lancelot SIX via Gdb-patches
2022-08-09 10:55   ` Tom de Vries via Gdb-patches
2022-08-11 14:07     ` Lancelot SIX via Gdb-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b46dde7-b1d6-da32-fe47-934f0046e72a@amd.com \
    --to=gdb-patches@sourceware.org \
    --cc=Lancelot.Six@amd.com \
    --cc=lsix@lancelotsix.com \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox