Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Andrew Burgess <aburgess@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] gdb: use get_current_frame consistently in print_stop_location
Date: Thu, 9 Apr 2026 15:43:19 +0200	[thread overview]
Message-ID: <4a5043ae-0554-4d09-b426-d42d5d66d972@suse.de> (raw)
In-Reply-To: <87o6js4ipn.fsf@redhat.com>

On 4/9/26 10:54 AM, Andrew Burgess wrote:
>> So I'm proposing a change to this patch (attached below, doesn't apply
>> to the first but to the second patch) that:
>> - introduces a variable print_frame
>> - assigns get_selected_frame (nullptr) to print_frame
>> - adds a comment explaining how print_frame relates to the stop frame
>> - uses print_frame everywhere in the function
>>
>> I tested the series in combination with the attached patch on
>> x86_64-linux, and found no regressions.
> Thanks for the great analysis, and explanation, I wasn't aware of this
> aspect of bpstat_print.  Given this new information, I think your patch
> is the right solution.
> 
> Approved-By: Andrew Burgess<aburgess@redhat.com>

Hi Andrew,

my initial idea here was that the patch I posted could be trivially 
merged with the first patch, but upon attempting this I ended up 
re-editing the series.  I'm currently testing this, and will submit if 
that goes ok.

The content of the patch series should be what you posted plus 
aforementioned patch, the changes I made are merely refactoring.

Thanks,
- Tom

  reply	other threads:[~2026-04-09 13:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31 13:23 [RFC v2 0/3] [gdb] Fix missing print frame when stepping out of function Tom de Vries
2026-03-31 13:23 ` [RFC v2 1/3] [gdb/symtab] Add find_symbol_for_pc_maybe_inline Tom de Vries
2026-03-31 13:23 ` [RFC v2 2/3] [gdb] Add thread_control_state::step_start_function methods Tom de Vries
2026-03-31 13:23 ` [RFC v2 3/3] [gdb] Fix missing print frame when stepping out of function Tom de Vries
2026-04-05 10:12 ` [PATCH 0/2] " Andrew Burgess
2026-04-05 10:12   ` [PATCH 1/2] gdb: use get_current_frame consistently in print_stop_location Andrew Burgess
2026-04-09  6:42     ` Tom de Vries
2026-04-09  8:54       ` Andrew Burgess
2026-04-09 13:43         ` Tom de Vries [this message]
2026-04-10  8:57           ` Andrew Burgess
2026-04-10 10:17             ` Tom de Vries
2026-04-05 10:12   ` [PATCH 2/2] gdb: fix missing print frame when stepping out of function Andrew Burgess
2026-04-10 10:29     ` Tom de Vries
2026-04-10 10:48   ` [PATCH 0/2] Fix " Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4a5043ae-0554-4d09-b426-d42d5d66d972@suse.de \
    --to=tdevries@suse.de \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox