From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YRwcHRat12lJ/g4AWB0awg (envelope-from ) for ; Thu, 09 Apr 2026 09:43:50 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=WWOC7vlI; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=9DggLPWn; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=WWOC7vlI; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=9DggLPWn; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 631531E0BC; Thu, 09 Apr 2026 09:43:50 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 39A011E04F for ; Thu, 09 Apr 2026 09:43:49 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id C26314BA2E38 for ; Thu, 9 Apr 2026 13:43:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C26314BA2E38 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=WWOC7vlI; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=9DggLPWn; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=WWOC7vlI; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=9DggLPWn Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id AB5CD4BA2E1E for ; Thu, 9 Apr 2026 13:43:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AB5CD4BA2E1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AB5CD4BA2E1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775742202; cv=none; b=BMF6tZvCLMAGRSeSK14TOKtDtdmqO/iN66rjgts1UeyXzot+Eng84m+VMYFVPvHBKjYCl+kGAqaU7l7m259E9tnWXJ/+QOantXs7um1vNivDVvPrzzi55Is/byzNWXGVoQtPFFgA8uQWBULDWJTusN7Cj7Tu/3nzfL4vBpYnpDI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775742202; c=relaxed/simple; bh=j4ROt+gRhYcsTBO/SAAp/SxXdaU1sUGblLp3VtcCoCg=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=HJztm5ZYgboE04AOQLW/tFjih/+LD3NOxR9Eq/h8qt2DPFTgdxNWxOv/fwo3DYZeSJ7zk2EwA0zuyOsXerKOeKqKDqImFN6Vb0NZ0gqglyrXFhx+fZhSN8w9biutrP1aKfQxc8Rayh/thnuifye2naOEO/SkM5Y+VrULmcmWFOM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AB5CD4BA2E1E Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B180E5BD28; Thu, 9 Apr 2026 13:43:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775742200; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wi3tkemIIEinRw2kAsSm/EfkzoiGng46BMX4iOon6+4=; b=WWOC7vlIyv9hCgF4m4EYeMYaHDJqIoGPaB5xoY9ry7ioHdYVV5p73FS+soAr7BL3pitiE5 zgo9Ce23lxu4AKpezChpbNLAM0c4JpoPMDjYugUjUuG8HDZAMen25BJ5PJDNqrFK3Xd7iK uEQ4OHAkRYf+zKmBRDCgqOhucKNUsrA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775742200; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wi3tkemIIEinRw2kAsSm/EfkzoiGng46BMX4iOon6+4=; b=9DggLPWnEcYYTC6ubGNP//9Z3R2569TKGsbgaYe0YHWojkko51uRiO0eVqPJ6DjEU43A+V qklB0X2ikUQZodAg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=WWOC7vlI; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=9DggLPWn DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775742200; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wi3tkemIIEinRw2kAsSm/EfkzoiGng46BMX4iOon6+4=; b=WWOC7vlIyv9hCgF4m4EYeMYaHDJqIoGPaB5xoY9ry7ioHdYVV5p73FS+soAr7BL3pitiE5 zgo9Ce23lxu4AKpezChpbNLAM0c4JpoPMDjYugUjUuG8HDZAMen25BJ5PJDNqrFK3Xd7iK uEQ4OHAkRYf+zKmBRDCgqOhucKNUsrA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775742200; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wi3tkemIIEinRw2kAsSm/EfkzoiGng46BMX4iOon6+4=; b=9DggLPWnEcYYTC6ubGNP//9Z3R2569TKGsbgaYe0YHWojkko51uRiO0eVqPJ6DjEU43A+V qklB0X2ikUQZodAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9401E4A0B3; Thu, 9 Apr 2026 13:43:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id BW6LIvis12nFTwAAD6G6ig (envelope-from ); Thu, 09 Apr 2026 13:43:20 +0000 Message-ID: <4a5043ae-0554-4d09-b426-d42d5d66d972@suse.de> Date: Thu, 9 Apr 2026 15:43:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] gdb: use get_current_frame consistently in print_stop_location To: Andrew Burgess , gdb-patches@sourceware.org References: <20260331132342.1050954-1-tdevries@suse.de> <640943dbfd2e2d6555be950b04a4c50288e3334a.1775383137.git.aburgess@redhat.com> <337213ec-dce2-47d2-b04a-21aaf3d849dc@suse.de> <87o6js4ipn.fsf@redhat.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87o6js4ipn.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_TLS_ALL(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Queue-Id: B180E5BD28 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/9/26 10:54 AM, Andrew Burgess wrote: >> So I'm proposing a change to this patch (attached below, doesn't apply >> to the first but to the second patch) that: >> - introduces a variable print_frame >> - assigns get_selected_frame (nullptr) to print_frame >> - adds a comment explaining how print_frame relates to the stop frame >> - uses print_frame everywhere in the function >> >> I tested the series in combination with the attached patch on >> x86_64-linux, and found no regressions. > Thanks for the great analysis, and explanation, I wasn't aware of this > aspect of bpstat_print. Given this new information, I think your patch > is the right solution. > > Approved-By: Andrew Burgess Hi Andrew, my initial idea here was that the patch I posted could be trivially merged with the first patch, but upon attempting this I ended up re-editing the series. I'm currently testing this, and will submit if that goes ok. The content of the patch series should be what you posted plus aforementioned patch, the changes I made are merely refactoring. Thanks, - Tom