From: asmwarrior <asmwarrior@gmail.com>
To: gdb-patches@sourceware.org
Cc: Doug Evans <dje@google.com>
Subject: Re: [RFA] Ignore DW_AT_ranges starting at zero if !has_section_at_zero
Date: Fri, 13 Jul 2012 01:33:00 -0000 [thread overview]
Message-ID: <4FFF7B94.8050407@gmail.com> (raw)
In-Reply-To: <20120712225036.6D0BB1E1268@ruffy2.mtv.corp.google.com>
On 2012-7-13 6:50, Doug Evans wrote:
> Hi.
>
> I was root-causing an instance of
> "pc 0x2a in read in psymtab, but not in symtab"
> and found that it was caused by an address range of 0-75 being
> recorded in the psymtab addrmap but not the symtab addrmap.
>
> The discrepancy between the two addrmaps is a separate patch,
> as is whether we can just have one addrmap instead of two.
> This patch ignores address ranges that begin at zero if there
> is no section at zero to avoid populating the tables with bad data.
>
> Ok to check in?
>
> 2012-07-12 Doug Evans <dje@google.com>
>
> * dwarf2read.c (dwarf2_ranges_read): Ignore ranges starting at zero if
> there's no section at address zero.
> (dwarf2_record_block_ranges): Ditto.
>
I tested your patch, it looks like the problem I reported in this comment:
http://sourceware.org/bugzilla/show_bug.cgi?id=8863#c3
was solved by this patch. Thanks.
asmwarrior
next prev parent reply other threads:[~2012-07-13 1:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 22:50 Doug Evans
2012-07-13 1:33 ` asmwarrior [this message]
2012-07-18 21:06 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFF7B94.8050407@gmail.com \
--to=asmwarrior@gmail.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox