From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2299 invoked by alias); 13 Jul 2012 01:33:44 -0000 Received: (qmail 2291 invoked by uid 22791); 13 Jul 2012 01:33:43 -0000 X-SWARE-Spam-Status: No, hits=-5.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-pb0-f41.google.com (HELO mail-pb0-f41.google.com) (209.85.160.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 Jul 2012 01:33:30 +0000 Received: by pbbrp2 with SMTP id rp2so5302274pbb.0 for ; Thu, 12 Jul 2012 18:33:29 -0700 (PDT) Received: by 10.68.223.138 with SMTP id qu10mr10271224pbc.50.1342143209617; Thu, 12 Jul 2012 18:33:29 -0700 (PDT) Received: from [192.168.1.128] ([115.193.202.218]) by mx.google.com with ESMTPS id ql3sm4898858pbc.72.2012.07.12.18.33.26 (version=SSLv3 cipher=OTHER); Thu, 12 Jul 2012 18:33:28 -0700 (PDT) Message-ID: <4FFF7B94.8050407@gmail.com> Date: Fri, 13 Jul 2012 01:33:00 -0000 From: asmwarrior User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: gdb-patches@sourceware.org CC: Doug Evans Subject: Re: [RFA] Ignore DW_AT_ranges starting at zero if !has_section_at_zero References: <20120712225036.6D0BB1E1268@ruffy2.mtv.corp.google.com> In-Reply-To: <20120712225036.6D0BB1E1268@ruffy2.mtv.corp.google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00172.txt.bz2 On 2012-7-13 6:50, Doug Evans wrote: > Hi. > > I was root-causing an instance of > "pc 0x2a in read in psymtab, but not in symtab" > and found that it was caused by an address range of 0-75 being > recorded in the psymtab addrmap but not the symtab addrmap. > > The discrepancy between the two addrmaps is a separate patch, > as is whether we can just have one addrmap instead of two. > This patch ignores address ranges that begin at zero if there > is no section at zero to avoid populating the tables with bad data. > > Ok to check in? > > 2012-07-12 Doug Evans > > * dwarf2read.c (dwarf2_ranges_read): Ignore ranges starting at zero if > there's no section at address zero. > (dwarf2_record_block_ranges): Ditto. > I tested your patch, it looks like the problem I reported in this comment: http://sourceware.org/bugzilla/show_bug.cgi?id=8863#c3 was solved by this patch. Thanks. asmwarrior