From: "Schnell, Fabian" <fabian.schnell@linux.intel.com>
To: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
Cc: Yao Qi <yao@codesourcery.com>,
gdb-patches@sourceware.org, Pedro Alves <palves@redhat.com>
Subject: Re: [patch] Support bionic's jmp_buf.
Date: Mon, 25 Jun 2012 20:49:00 -0000 [thread overview]
Message-ID: <4FE8CEE6.1020308@linux.intel.com> (raw)
In-Reply-To: <1340646873.31308.30.camel@hactar>
On 6/25/2012 10:54 AM, Thiago Jung Bauermann wrote:
> Hello,
>
> On Mon, 2012-06-25 at 21:32 +0800, Yao Qi wrote:
>> On Sunday, June 24, 2012 06:46:15 PM Thiago Jung Bauermann wrote:
>>> +/* Determines whether the inferior is an Android application. */
>>> +
>>> +static int
>>> +is_target_linux_android (void)
>> Looks this function is not arm-specific, so we can move it to linux-tdep.c.
> Thanks for your review.
>
> Android is officially supported on ARM and x86. I don't know how GDB
> fares on Android on x86, and at least for now it will only be used on
> ARM (I don't have plans to work on Android on x86).
>
> With that said, I'm happy to move to linux-tdep.c if that makes more
> sense. I'll do the change before I commit or on the next iteration of
> the patch if there is one.
>
Looking at the original patch, the code is not required for bionic on x86.
Yet, to have this function in a shared location might make it easier to
code dependencies in the future.
- Fabian
next prev parent reply other threads:[~2012-06-25 20:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 0:36 Thiago Jung Bauermann
2012-05-21 11:38 ` Pedro Alves
2012-05-21 17:59 ` Thiago Jung Bauermann
2012-06-24 21:46 ` Thiago Jung Bauermann
2012-06-25 13:32 ` Yao Qi
2012-06-25 17:55 ` Thiago Jung Bauermann
2012-06-25 20:49 ` Schnell, Fabian [this message]
2012-06-27 10:18 ` Pedro Alves
2012-07-04 21:08 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE8CEE6.1020308@linux.intel.com \
--to=fabian.schnell@linux.intel.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=thiago.bauermann@linaro.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox