From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30277 invoked by alias); 25 Jun 2012 20:49:56 -0000 Received: (qmail 30264 invoked by uid 22791); 25 Jun 2012 20:49:55 -0000 X-SWARE-Spam-Status: No, hits=-8.0 required=5.0 tests=BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mga01.intel.com (HELO mga01.intel.com) (192.55.52.88) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 25 Jun 2012 20:49:43 +0000 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 25 Jun 2012 13:49:42 -0700 X-ExtLoop1: 1 Received: from fschnell-mobl4.amr.corp.intel.com (HELO [10.254.23.128]) ([10.254.23.128]) by fmsmga001.fm.intel.com with ESMTP; 25 Jun 2012 13:49:42 -0700 Message-ID: <4FE8CEE6.1020308@linux.intel.com> Date: Mon, 25 Jun 2012 20:49:00 -0000 From: "Schnell, Fabian" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Thiago Jung Bauermann CC: Yao Qi , gdb-patches@sourceware.org, Pedro Alves Subject: Re: [patch] Support bionic's jmp_buf. References: <1337560528.4363.13.camel@hactar> <1337623164.22073.9.camel@hactar> <1340574375.31308.7.camel@hactar> <2077698.dhnsbKdz32@qiyao.dyndns.org> <1340646873.31308.30.camel@hactar> In-Reply-To: <1340646873.31308.30.camel@hactar> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00787.txt.bz2 On 6/25/2012 10:54 AM, Thiago Jung Bauermann wrote: > Hello, > > On Mon, 2012-06-25 at 21:32 +0800, Yao Qi wrote: >> On Sunday, June 24, 2012 06:46:15 PM Thiago Jung Bauermann wrote: >>> +/* Determines whether the inferior is an Android application. */ >>> + >>> +static int >>> +is_target_linux_android (void) >> Looks this function is not arm-specific, so we can move it to linux-tdep.c. > Thanks for your review. > > Android is officially supported on ARM and x86. I don't know how GDB > fares on Android on x86, and at least for now it will only be used on > ARM (I don't have plans to work on Android on x86). > > With that said, I'm happy to move to linux-tdep.c if that makes more > sense. I'll do the change before I commit or on the next iteration of > the patch if there is one. > Looking at the original patch, the code is not required for bionic on x86. Yet, to have this function in a shared location might make it easier to code dependencies in the future. - Fabian