From: Jeff Kenton <jkenton@tilera.com>
To: Pedro Alves <palves@redhat.com>
Cc: Joel Brobecker <brobecker@adacore.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Add support for Tilera TILE-Gx processor (part 1/3: gdb)
Date: Wed, 30 May 2012 20:09:00 -0000 [thread overview]
Message-ID: <4FC67E5E.20507@tilera.com> (raw)
In-Reply-To: <4FC67B1C.6040700@redhat.com>
On 05/30/2012 03:55 PM, Pedro Alves wrote:
> Hi Jeff,
>
> Please always send patches against the current mainline; the "tilegx_return_value"
> function had a function signature that is no longer correct in mainline, and thus
> caused an --enable-targets=all build to fail. I've fixed it.
>
> I've also went through the patch and updated a series of formatting
> issues (tabs/spaces, some alignments, etc.) and a few typos/pastos, as it was more
> efficient that more back and forth. ;-) I've also done a couple other minor
> things, like adding multiple inclusion guards to tilegx-tdep.h.
>
> Here's the patch as checked in.
>
>
Thank you.
--jeff kenton
next prev parent reply other threads:[~2012-05-30 20:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 16:09 Jeff Kenton
2012-05-14 16:21 ` Joel Brobecker
2012-05-21 14:23 ` Jeff Kenton
2012-05-23 17:34 ` Pedro Alves
2012-05-24 19:26 ` Jeff Kenton
2012-05-25 15:17 ` Pedro Alves
2012-05-29 15:24 ` Jeff Kenton
2012-05-30 19:56 ` Pedro Alves
2012-05-30 20:09 ` Jeff Kenton [this message]
2012-05-31 8:53 ` [patch] Compilation regression on older gcc + 32-bit host [Re: [PATCH] Add support for Tilera TILE-Gx processor (part 1/3: gdb)] Jan Kratochvil
2012-05-31 10:05 ` Pedro Alves
2012-05-31 15:40 ` [patch] Require long long for GDB [Re: [patch] Compilation regression on older gcc + 32-bit host] Jan Kratochvil
2012-06-01 14:45 ` [commit] Fix tilegx-linux-tdep.c compilation [Re: [patch] Require long long for GDB] Jan Kratochvil
2012-05-29 15:24 ` [PATCH] Add support for Tilera TILE-Gx processor (part 1/3: gdb) Jeff Kenton
2012-05-29 17:11 ` Jeff Kenton
2012-05-14 16:24 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC67E5E.20507@tilera.com \
--to=jkenton@tilera.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox