From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-91613-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30142 invoked by alias); 30 May 2012 20:09:18 -0000
Received: (qmail 30132 invoked by uid 22791); 30 May 2012 20:09:16 -0000
X-SWARE-Spam-Status: No, hits=-3.0 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,TW_EG,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from usmamail.tilera.com (HELO USMAMAIL.TILERA.COM) (12.216.194.151)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 30 May 2012 20:09:03 +0000
Received: from [10.7.0.51] (10.9.0.23) by USMAExch2.tad.internal.tilera.com (10.3.0.33) with Microsoft SMTP Server id 14.0.694.0; Wed, 30 May 2012 16:09:02 -0400
Message-ID: <4FC67E5E.20507@tilera.com>
Date: Wed, 30 May 2012 20:09:00 -0000
From: Jeff Kenton <jkenton@tilera.com>
User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:6.0.2) Gecko/20110902 Thunderbird/6.0.2
MIME-Version: 1.0
To: Pedro Alves <palves@redhat.com>
CC: Joel Brobecker <brobecker@adacore.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Add support for Tilera TILE-Gx processor (part 1/3: gdb)
References: <4FAD39A1.1000209@tilera.com> <20120514162046.GI10253@adacore.com> <4FBA4FD2.9090108@tilera.com> <4FBD1F67.9090609@redhat.com> <4FBE8B5E.6050800@tilera.com> <4FBFA26F.20002@redhat.com> <4FC4EA20.1040201@tilera.com> <4FC67B1C.6040700@redhat.com>
In-Reply-To: <4FC67B1C.6040700@redhat.com>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-05/txt/msg01055.txt.bz2

On 05/30/2012 03:55 PM, Pedro Alves wrote:
> Hi Jeff,
>

> Please always send patches against the current mainline; the "tilegx_return_value"
> function had a function signature that is no longer correct in mainline, and thus
> caused an --enable-targets=all build to fail.  I've fixed it.
>
> I've also went through the patch and updated a series of formatting
> issues (tabs/spaces, some alignments, etc.) and a few typos/pastos, as it was more
> efficient that more back and forth.  ;-)  I've also done a couple other minor
> things, like adding multiple inclusion guards to tilegx-tdep.h.
>
> Here's the patch as checked in.
>
>

Thank you.

--jeff kenton