From: Pedro Alves <palves@redhat.com>
To: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [RFA] Define DT_MIPS_RLD_MAP if not already defined.
Date: Wed, 30 May 2012 18:50:00 -0000 [thread overview]
Message-ID: <4FC66BDC.1030200@redhat.com> (raw)
In-Reply-To: <1338402935.22894.12.camel@hactar>
On 05/30/2012 07:35 PM, Thiago Jung Bauermann wrote:
> On Wed, 2012-05-30 at 19:03 +0100, Pedro Alves wrote:
>> On 05/30/2012 05:40 AM, Thiago Jung Bauermann wrote:
>>> Hello,
>>>
>>> Android doesn't support MIPS, so understandably there's no
>>> DT_MIPS_RLD_MAP in its header files. This patch allows gdbserver to be
>>> compiled for Android.
>>
>> Then why not '#ifdef DT_MIPS_RLD_MAP' out the bits that use DT_MIPS_RLD_MAP ?
>> It's just dead code on non-MIPS ports.
>
> I thought #ifdef'ing platform-specific code was discouraged in GDB. I
> can certainly do that though.
It is, mostly in common code. But this is native code. The alternative
is to abstract it in the linux_target_ops interface, but that's quite
overkill for this. Plenty of other #ifdefs in linux-low.c.
--
Pedro Alves
next prev parent reply other threads:[~2012-05-30 18:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 4:40 Thiago Jung Bauermann
2012-05-30 18:03 ` Pedro Alves
2012-05-30 18:36 ` Thiago Jung Bauermann
2012-05-30 18:50 ` Pedro Alves [this message]
2012-05-30 19:27 ` Thiago Jung Bauermann
2012-05-30 19:29 ` Pedro Alves
2012-05-30 19:52 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC66BDC.1030200@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=thiago.bauermann@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox