From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5797 invoked by alias); 30 May 2012 18:50:25 -0000 Received: (qmail 5788 invoked by uid 22791); 30 May 2012 18:50:24 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 30 May 2012 18:50:08 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4UIo7dO029630 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 30 May 2012 14:50:07 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q4UIo5se028009; Wed, 30 May 2012 14:50:06 -0400 Message-ID: <4FC66BDC.1030200@redhat.com> Date: Wed, 30 May 2012 18:50:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Thiago Jung Bauermann CC: gdb-patches ml Subject: Re: [RFA] Define DT_MIPS_RLD_MAP if not already defined. References: <1338352816.3618.5.camel@hactar> <4FC660E6.9010904@redhat.com> <1338402935.22894.12.camel@hactar> In-Reply-To: <1338402935.22894.12.camel@hactar> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg01048.txt.bz2 On 05/30/2012 07:35 PM, Thiago Jung Bauermann wrote: > On Wed, 2012-05-30 at 19:03 +0100, Pedro Alves wrote: >> On 05/30/2012 05:40 AM, Thiago Jung Bauermann wrote: >>> Hello, >>> >>> Android doesn't support MIPS, so understandably there's no >>> DT_MIPS_RLD_MAP in its header files. This patch allows gdbserver to be >>> compiled for Android. >> >> Then why not '#ifdef DT_MIPS_RLD_MAP' out the bits that use DT_MIPS_RLD_MAP ? >> It's just dead code on non-MIPS ports. > > I thought #ifdef'ing platform-specific code was discouraged in GDB. I > can certainly do that though. It is, mostly in common code. But this is native code. The alternative is to abstract it in the linux_target_ops interface, but that's quite overkill for this. Plenty of other #ifdefs in linux-low.c. -- Pedro Alves