Re: [PATCH] disable ptrace BookE interface for PowerPC server processors

[Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>]

On 05/29/2012 03:54 PM, Mark Kettenis wrote:

>> Date: Fri, 25 May 2012 00:49:39 -0300
>> From: Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
>>
>> On 05/22/2012 02:34 PM, Mark Kettenis wrote:
>>
>>> But how are you going to handle this when that functionality does
>>> become available?  
>>
>>
>> Thanks for the feedback and sorry for the late reply. I was discussing
>> with the kernel developer responsible for the next version of the ptrace
>> booke interface and he proposed that the 'features' field from the
>> struct ppc_debug_info returned by ptrace PPC_PTRACE_GETHWDBGINFO call
>> could be used to check if its availability. According to him, this field
>> is currently 0 for servers, but once the new ptrace interface becomes
>> functional, it will return the flag PPC_DEBUG_FEATURE_DATA_BP_RANGE
>> enabled. Moreover, this change will not affect the behavior on embedded
>> processors (which already has PPC_DEBUG_FEATURE_DATA_BP_RANGE and
>> PPC_DEBUG_FEATURE_DATA_BP_MASK enabled).
>>
>> Please consider the new version of the patch below.
> 
> Certainly makes more sense to me ;)


which means this is ok to apply? :)

Thanks for the review once again, Mark.

-- 
Edjunior