From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32708 invoked by alias); 30 May 2012 04:17:26 -0000 Received: (qmail 32699 invoked by uid 22791); 30 May 2012 04:17:24 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e24smtp03.br.ibm.com (HELO e24smtp03.br.ibm.com) (32.104.18.24) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 30 May 2012 04:17:11 +0000 Received: from /spool/local by e24smtp03.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 30 May 2012 01:17:09 -0300 Received: from d24dlp01.br.ibm.com (9.18.248.204) by e24smtp03.br.ibm.com (10.172.0.139) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 30 May 2012 01:16:41 -0300 Received: from d24relay01.br.ibm.com (d24relay01.br.ibm.com [9.8.31.16]) by d24dlp01.br.ibm.com (Postfix) with ESMTP id C96E9352004B for ; Wed, 30 May 2012 01:16:35 -0300 (BRT) Received: from d24av05.br.ibm.com (d24av05.br.ibm.com [9.18.232.44]) by d24relay01.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q4U4ERtk3158086 for ; Wed, 30 May 2012 01:14:27 -0300 Received: from d24av05.br.ibm.com (loopback [127.0.0.1]) by d24av05.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q4U4GdvQ008405 for ; Wed, 30 May 2012 01:16:39 -0300 Received: from [9.12.227.77] ([9.12.227.77]) by d24av05.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q4U4Gbx9008390; Wed, 30 May 2012 01:16:38 -0300 Message-ID: <4FC59F24.1060907@linux.vnet.ibm.com> Date: Wed, 30 May 2012 04:17:00 -0000 From: Edjunior Barbosa Machado User-Agent: Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Mark Kettenis CC: gdb-patches@sourceware.org, prasad@linux.vnet.ibm.com Subject: Re: [PATCH] disable ptrace BookE interface for PowerPC server processors References: <1337700251-9366-1-git-send-email-emachado@linux.vnet.ibm.com> <201205221734.q4MHY0FQ014975@glazunov.sibelius.xs4all.nl> <4FBF0153.4060108@linux.vnet.ibm.com> <201205291854.q4TIsH0i008399@glazunov.sibelius.xs4all.nl> In-Reply-To: <201205291854.q4TIsH0i008399@glazunov.sibelius.xs4all.nl> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12053004-9254-0000-0000-000009231A31 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg01036.txt.bz2 On 05/29/2012 03:54 PM, Mark Kettenis wrote: >> Date: Fri, 25 May 2012 00:49:39 -0300 >> From: Edjunior Barbosa Machado >> >> On 05/22/2012 02:34 PM, Mark Kettenis wrote: >> >>> But how are you going to handle this when that functionality does >>> become available? >> >> >> Thanks for the feedback and sorry for the late reply. I was discussing >> with the kernel developer responsible for the next version of the ptrace >> booke interface and he proposed that the 'features' field from the >> struct ppc_debug_info returned by ptrace PPC_PTRACE_GETHWDBGINFO call >> could be used to check if its availability. According to him, this field >> is currently 0 for servers, but once the new ptrace interface becomes >> functional, it will return the flag PPC_DEBUG_FEATURE_DATA_BP_RANGE >> enabled. Moreover, this change will not affect the behavior on embedded >> processors (which already has PPC_DEBUG_FEATURE_DATA_BP_RANGE and >> PPC_DEBUG_FEATURE_DATA_BP_MASK enabled). >> >> Please consider the new version of the patch below. > > Certainly makes more sense to me ;) which means this is ok to apply? :) Thanks for the review once again, Mark. -- Edjunior