From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: Mike Frysinger <vapier@gentoo.org>,"H.J. Lu" <hjl.tools@gmail.com>
Cc: Binutils <binutils@sourceware.org>,GDB
<gdb-patches@sourceware.org>,GCC Patches
<gcc-patches@gcc.gnu.org>
Subject: Re: PATCH: Update --with-system-zlib
Date: Wed, 01 Apr 2015 17:05:00 -0000 [thread overview]
Message-ID: <4FC39AF9-5742-4F8C-80F0-93E382080969@gmail.com> (raw)
In-Reply-To: <20150401165431.GL25224@vapier>
On April 1, 2015 6:54:31 PM GMT+02:00, Mike Frysinger <vapier@gentoo.org> wrote:
>On 01 Apr 2015 05:04, H.J. Lu wrote:
>> --- a/config/zlib.m4
>> +++ b/config/zlib.m4
>> @@ -9,8 +9,10 @@ AC_DEFUN([AM_ZLIB],
>> zlibinc="-I\$(srcdir)/../zlib"
>> AC_ARG_WITH(system-zlib,
>> [AS_HELP_STRING([--with-system-zlib], [use installed libz])],
>> - zlibdir=
>> - zlibinc=
>> + if test x$with_system_zlib = xyes ; then
>> + zlibdir=
>> + zlibinc=
>> + fi
>> )
>
>this is inside the 3rd arg, so normally you check $withval. this code
>will
>still work as the generated shell does:
>if test "${with_system_zlib+set}" = set; then :
Why doesn't this expand to test -n "${with_system_zlib+set}"
nowadays, BTW? Would be faster to parse and supposedly sums up quite a bit, fwiw.
Cheers,
> withval=$with_system_zlib; [3rd arg content]
>fi
>
>> bfd/ChangeLog | 4 ++++
>> bfd/configure | 6 ++++--
>> binutils/ChangeLog | 4 ++++
>> binutils/configure | 6 ++++--
>> gas/ChangeLog | 4 ++++
>> gas/configure | 6 ++++--
>> gdb/ChangeLog | 4 ++++
>> gdb/configure | 6 ++++--
>
>you need to regenerate the sim tree too
>-mike
next prev parent reply other threads:[~2015-04-01 17:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-01 12:04 H.J. Lu
2015-04-01 16:54 ` Mike Frysinger
2015-04-01 17:05 ` Bernhard Reutner-Fischer [this message]
2015-04-01 17:17 ` Mike Frysinger
2015-04-01 17:17 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC39AF9-5742-4F8C-80F0-93E382080969@gmail.com \
--to=rep.dot.nop@gmail.com \
--cc=binutils@sourceware.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox