From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59756 invoked by alias); 1 Apr 2015 17:05:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 59688 invoked by uid 89); 1 Apr 2015 17:05:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KAM_FROM_URIBL_PCCC,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-wi0-f181.google.com Received: from mail-wi0-f181.google.com (HELO mail-wi0-f181.google.com) (209.85.212.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 01 Apr 2015 17:05:28 +0000 Received: by wixm2 with SMTP id m2so39922304wix.0; Wed, 01 Apr 2015 10:05:25 -0700 (PDT) X-Received: by 10.180.90.243 with SMTP id bz19mr5952259wib.47.1427907925486; Wed, 01 Apr 2015 10:05:25 -0700 (PDT) Received: from [10.33.81.41] (089144201041.atnat0010.highway.a1.net. [89.144.201.41]) by mx.google.com with ESMTPSA id dn7sm26288520wid.12.2015.04.01.10.05.23 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Apr 2015 10:05:24 -0700 (PDT) User-Agent: K-9 Mail for Android In-Reply-To: <20150401165431.GL25224@vapier> References: <20150401165431.GL25224@vapier> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Subject: Re: PATCH: Update --with-system-zlib From: Bernhard Reutner-Fischer Date: Wed, 01 Apr 2015 17:05:00 -0000 To: Mike Frysinger ,"H.J. Lu" CC: Binutils ,GDB ,GCC Patches Message-ID: <4FC39AF9-5742-4F8C-80F0-93E382080969@gmail.com> X-SW-Source: 2015-04/txt/msg00064.txt.bz2 On April 1, 2015 6:54:31 PM GMT+02:00, Mike Frysinger wrote: >On 01 Apr 2015 05:04, H.J. Lu wrote: >> --- a/config/zlib.m4 >> +++ b/config/zlib.m4 >> @@ -9,8 +9,10 @@ AC_DEFUN([AM_ZLIB], >> zlibinc="-I\$(srcdir)/../zlib" >> AC_ARG_WITH(system-zlib, >> [AS_HELP_STRING([--with-system-zlib], [use installed libz])], >> - zlibdir= >> - zlibinc= >> + if test x$with_system_zlib = xyes ; then >> + zlibdir= >> + zlibinc= >> + fi >> ) > >this is inside the 3rd arg, so normally you check $withval. this code >will >still work as the generated shell does: >if test "${with_system_zlib+set}" = set; then : Why doesn't this expand to test -n "${with_system_zlib+set}" nowadays, BTW? Would be faster to parse and supposedly sums up quite a bit, fwiw. Cheers, > withval=$with_system_zlib; [3rd arg content] >fi > >> bfd/ChangeLog | 4 ++++ >> bfd/configure | 6 ++++-- >> binutils/ChangeLog | 4 ++++ >> binutils/configure | 6 ++++-- >> gas/ChangeLog | 4 ++++ >> gas/configure | 6 ++++-- >> gdb/ChangeLog | 4 ++++ >> gdb/configure | 6 ++++-- > >you need to regenerate the sim tree too >-mike