From: Pedro Alves <palves@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: "gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: [RFA] Suppress stap-trace.exp when compilation fails
Date: Wed, 23 May 2012 17:37:00 -0000 [thread overview]
Message-ID: <4FBD203E.1010004@redhat.com> (raw)
In-Reply-To: <4FBD1B16.7080606@redhat.com>
On 05/23/2012 06:15 PM, Keith Seitz wrote:
> Hi,
>
> stap-trace.exp does not check the return value of its compile-a-testcase wrapper procedure, so when compilation of the test case fails, it attempts to run the tests anyway instead of nicely bailing out.
>
> This patch addresses this by fixing the compile wrapper to always return a valid value and checking this procedure's return value before running the tests.
>
> Okay?
Sure, thanks. There's a second compilation further below, but I'll assume that if
the first succeeds, the second should also.
--
Pedro Alves
next prev parent reply other threads:[~2012-05-23 17:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-23 17:15 Keith Seitz
2012-05-23 17:34 ` Sergio Durigan Junior
2012-05-23 17:37 ` Pedro Alves [this message]
2012-05-23 18:21 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBD203E.1010004@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox