From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16051 invoked by alias); 23 May 2012 17:37:18 -0000 Received: (qmail 15996 invoked by uid 22791); 23 May 2012 17:37:18 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 23 May 2012 17:37:04 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4NHb4pD014171 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 23 May 2012 13:37:04 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q4NHb2Qp024335; Wed, 23 May 2012 13:37:03 -0400 Message-ID: <4FBD203E.1010004@redhat.com> Date: Wed, 23 May 2012 17:37:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Keith Seitz CC: "gdb-patches@sourceware.org ml" Subject: Re: [RFA] Suppress stap-trace.exp when compilation fails References: <4FBD1B16.7080606@redhat.com> In-Reply-To: <4FBD1B16.7080606@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00907.txt.bz2 On 05/23/2012 06:15 PM, Keith Seitz wrote: > Hi, > > stap-trace.exp does not check the return value of its compile-a-testcase wrapper procedure, so when compilation of the test case fails, it attempts to run the tests anyway instead of nicely bailing out. > > This patch addresses this by fixing the compile wrapper to always return a valid value and checking this procedure's return value before running the tests. > > Okay? Sure, thanks. There's a second compilation further below, but I'll assume that if the first succeeds, the second should also. -- Pedro Alves