From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [2/5] make print_address_demangle use hex for 0
Date: Wed, 16 May 2012 20:58:00 -0000 [thread overview]
Message-ID: <4FB414DF.8050603@redhat.com> (raw)
In-Reply-To: <873972wnii.fsf@fleche.redhat.com>
On 05/14/2012 08:50 PM, Tom Tromey wrote:
> --- a/gdb/printcmd.c
> +++ b/gdb/printcmd.c
> @@ -773,7 +773,7 @@ print_address_demangle (const struct value_print_options *opts,
> {
> if (addr == 0)
> {
> - fprintf_filtered (stream, "0");
> + fprintf_filtered (stream, "0x0");
> }
> else if (opts->addressprint)
Do you know why we special case 0 at all? (There are targets where 0 is a valid address.)
--
Pedro Alves
next prev parent reply other threads:[~2012-05-16 20:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 19:50 Tom Tromey
2012-05-16 20:58 ` Pedro Alves [this message]
2012-05-16 21:04 ` Tom Tromey
2012-05-18 15:26 ` Tom Tromey
2012-05-18 15:42 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB414DF.8050603@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox