From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-91189-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18216 invoked by alias); 16 May 2012 20:58:22 -0000
Received: (qmail 18206 invoked by uid 22791); 16 May 2012 20:58:21 -0000
X-SWARE-Spam-Status: No, hits=-7.4 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 16 May 2012 20:58:09 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4GKw8tc005337	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Wed, 16 May 2012 16:58:08 -0400
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q4GKw7tc001751;	Wed, 16 May 2012 16:58:08 -0400
Message-ID: <4FB414DF.8050603@redhat.com>
Date: Wed, 16 May 2012 20:58:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1
MIME-Version: 1.0
To: Tom Tromey <tromey@redhat.com>
CC: gdb-patches@sourceware.org
Subject: Re: [2/5] make print_address_demangle use hex for 0
References: <873972wnii.fsf@fleche.redhat.com>
In-Reply-To: <873972wnii.fsf@fleche.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-05/txt/msg00631.txt.bz2

On 05/14/2012 08:50 PM, Tom Tromey wrote:

> --- a/gdb/printcmd.c
> +++ b/gdb/printcmd.c
> @@ -773,7 +773,7 @@ print_address_demangle (const struct value_print_options *opts,
>  {
>    if (addr == 0)
>      {
> -      fprintf_filtered (stream, "0");
> +      fprintf_filtered (stream, "0x0");
>      }
>    else if (opts->addressprint)


Do you know why we special case 0 at all?  (There are targets where 0 is a valid address.)

-- 
Pedro Alves