Fix AMD64 GNU/Linux build [Re: src/gdb ChangeLog amd64-linux-tdep.c]

Fix AMD64 GNU/Linux build [Re: src/gdb ChangeLog amd64-linux-tdep.c]

[Pedro Alves]

On 05/11/2012 11:31 PM, hjl@sourceware.org wrote:

> CVSROOT:	/cvs/src
> Module name:	src
> Changes by:	hjl@sourceware.org	2012-05-11 22:31:27
> 
> Modified files:
> 	gdb            : ChangeLog amd64-linux-tdep.c 
> 
> Log message:
> 	Include 32-linux.c and x32-avx-linux.c
> 	
> 	* amd64-linux-tdep.c: Include features/i386/x32-linux.c
> 	and features/i386/x32-avx-linux.c.
> 
> Patches:
> http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.14240&r2=1.14241
> http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/amd64-linux-tdep.c.diff?cvsroot=src&r1=1.47&r2=1.48
> 


gcc -g3 -O0   -I. -I../../src/gdb -I../../src/gdb/common -I../../src/gdb/config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode -I../../src/gdb/../opcodes/.. -I../../src/gdb/../readline/.. -I../bfd -I../../src/gdb/../bfd -I../../src/gdb/../include -I../libdecnumber -I../../src/gdb/../libdecnumber  -I../../src/gdb/gnulib/import -Ibuild-gnulib/import   -DTUI=1  -I/usr/include/python2.7 -I/usr/include/python2.7 -Wall -Wdeclaration-after-statement -Wpointer-arith -Wformat-nonliteral -Wno-pointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wmissing-prototypes -Werror -c -o amd64-linux-tdep.o -MT amd64-linux-tdep.o -MMD -MP -MF .deps/amd64-linux-tdep.Tpo ../../src/gdb/amd64-linux-tdep.c
../../src/gdb/features/i386/x32-linux.c:9:1: error: ‘initialize_tdesc_x32_linux’ defined but not used [-Werror=unused-function]
../../src/gdb/features/i386/x32-avx-linux.c:9:1: error: ‘initialize_tdesc_x32_avx_linux’ defined but not used [-Werror=unused-function]
cc1: all warnings being treated as errors
make: *** [amd64-linux-tdep.o] Error 1

Calls to initialize the newly included tdescs were missing.  Applied.

2012-05-12  Pedro Alves  <palves@redhat.com>

	* amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Call
	initialize_tdesc_x32_linux and initialize_tdesc_x32_avx_linux.
---
 gdb/amd64-linux-tdep.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/gdb/amd64-linux-tdep.c b/gdb/amd64-linux-tdep.c
index cfe6e4b..22a3464 100644
--- a/gdb/amd64-linux-tdep.c
+++ b/gdb/amd64-linux-tdep.c
@@ -1557,4 +1557,6 @@ _initialize_amd64_linux_tdep (void)
   /* Initialize the Linux target description.  */
   initialize_tdesc_amd64_linux ();
   initialize_tdesc_amd64_avx_linux ();
+  initialize_tdesc_x32_linux ();
+  initialize_tdesc_x32_avx_linux ();
 }

Re: Fix AMD64 GNU/Linux build [Re: src/gdb ChangeLog amd64-linux-tdep.c]

[H.J. Lu]

On Sat, May 12, 2012 at 1:55 AM, Pedro Alves <palves@redhat.com> wrote:
> On 05/11/2012 11:31 PM, hjl@sourceware.org wrote:
>
>> CVSROOT:      /cvs/src
>> Module name:  src
>> Changes by:   hjl@sourceware.org      2012-05-11 22:31:27
>>
>> Modified files:
>>       gdb            : ChangeLog amd64-linux-tdep.c
>>
>> Log message:
>>       Include 32-linux.c and x32-avx-linux.c
>>
>>       * amd64-linux-tdep.c: Include features/i386/x32-linux.c
>>       and features/i386/x32-avx-linux.c.
>>
>> Patches:
>> http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.14240&r2=1.14241
>> http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/amd64-linux-tdep.c.diff?cvsroot=src&r1=1.47&r2=1.48
>>
>
>
> gcc -g3 -O0   -I. -I../../src/gdb -I../../src/gdb/common -I../../src/gdb/config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode -I../../src/gdb/../opcodes/.. -I../../src/gdb/../readline/.. -I../bfd -I../../src/gdb/../bfd -I../../src/gdb/../include -I../libdecnumber -I../../src/gdb/../libdecnumber  -I../../src/gdb/gnulib/import -Ibuild-gnulib/import   -DTUI=1  -I/usr/include/python2.7 -I/usr/include/python2.7 -Wall -Wdeclaration-after-statement -Wpointer-arith -Wformat-nonliteral -Wno-pointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wmissing-prototypes -Werror -c -o amd64-linux-tdep.o -MT amd64-linux-tdep.o -MMD -MP -MF .deps/amd64-linux-tdep.Tpo ../../src/gdb/amd64-linux-tdep.c
> ../../src/gdb/features/i386/x32-linux.c:9:1: error: ‘initialize_tdesc_x32_linux’ defined but not used [-Werror=unused-function]
> ../../src/gdb/features/i386/x32-avx-linux.c:9:1: error: ‘initialize_tdesc_x32_avx_linux’ defined but not used [-Werror=unused-function]
> cc1: all warnings being treated as errors
> make: *** [amd64-linux-tdep.o] Error 1
>
> Calls to initialize the newly included tdescs were missing.  Applied.
>
> 2012-05-12  Pedro Alves  <palves@redhat.com>
>
>        * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Call
>        initialize_tdesc_x32_linux and initialize_tdesc_x32_avx_linux.
> ---

Thanks.


-- 
H.J.